Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling in active_campaign #2843

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Nov 21, 2023

Description of the change

As part of the mentioned destinations logic, we are sending the whole AxiosError object while we are sending data back to destination

  • active_campaign

As part of this PR, we are adding error handling for above mentioned destinations

Resolves INT-1110

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sanpj2292 sanpj2292 self-assigned this Nov 21, 2023
koladilip
koladilip previously approved these changes Nov 22, 2023
src/v0/destinations/active_campaign/util.js Outdated Show resolved Hide resolved
src/v0/destinations/active_campaign/util.js Outdated Show resolved Hide resolved
src/v0/destinations/active_campaign/util.js Outdated Show resolved Hide resolved
src/v0/destinations/active_campaign/util.js Outdated Show resolved Hide resolved
Signed-off-by: Sai Sankeerth <[email protected]>
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (1a8d825) 87.26% compared to head (422b15c) 87.26%.

Files Patch % Lines
src/v0/destinations/active_campaign/transform.js 16.66% 5 Missing ⚠️
src/v0/destinations/active_campaign/util.js 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2843      +/-   ##
===========================================
- Coverage    87.26%   87.26%   -0.01%     
===========================================
  Files          775      775              
  Lines        28925    28923       -2     
  Branches      6789     6788       -1     
===========================================
- Hits         25241    25239       -2     
  Misses        3344     3344              
  Partials       340      340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

saikumarrs
saikumarrs previously approved these changes Nov 29, 2023
@sanpj2292 sanpj2292 marked this pull request as ready for review November 30, 2023 13:41
@sanpj2292 sanpj2292 requested a review from a team as a code owner November 30, 2023 13:41
Copy link
Contributor

coderabbitai bot commented Nov 30, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

koladilip
koladilip previously approved these changes Dec 1, 2023
@sanpj2292 sanpj2292 dismissed stale reviews from saikumarrs and koladilip via 422b15c December 1, 2023 05:37
@sanpj2292 sanpj2292 changed the title fix: error handling fix: error handling in active_campaign Dec 1, 2023
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

15.4% 15.4% Coverage
11.8% 11.8% Duplication

@sanpj2292 sanpj2292 merged commit a015460 into develop Dec 1, 2023
17 of 18 checks passed
@sanpj2292 sanpj2292 deleted the fix.error-handling branch December 1, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants