fix: lowercase null check for track event adobe analytics #2840

aashishmalik · 2023-11-20T09:52:17Z

Description of the change

lowercase null check for track event adobe analytics

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

krishna2020 · 2023-11-20T12:39:00Z

src/v0/destinations/adobe_analytics/transform.js

@@ -306,7 +306,7 @@ const processTrackEvent = (message, adobeEventName, destinationConfig, extras =
    destinationConfig;
  const { event: rawMessageEvent, properties } = message;
  const { overrideEventString, overrideProductString } = properties;
-  const event = rawMessageEvent.toLowerCase();
+  const event = rawMessageEvent?.toString()?.toLowerCase();


can we have util to check for

event mandatory ?

event exists ?

event exists & not object

event is string & then lowercase conversion

codecov · 2023-11-21T10:33:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.20%. Comparing base (2380f9d) to head (7b8dfb7).
Report is 191 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2840   +/-   ##
========================================
  Coverage    87.20%   87.20%           
========================================
  Files          864      864           
  Lines        29373    29373           
  Branches      6854     6854           
========================================
  Hits         25616    25616           
  Misses        3411     3411           
  Partials       346      346

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonarqubecloud · 2023-11-21T10:33:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

coderabbitai · 2024-01-04T10:47:34Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

You can directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
- @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

sonarqubecloud · 2024-01-04T10:53:41Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

devops-github-rudderstack · 2024-01-25T01:27:28Z

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

devops-github-rudderstack · 2024-02-16T01:22:27Z

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

devops-github-rudderstack · 2024-03-08T01:22:23Z

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

aashishmalik requested a review from a team as a code owner November 20, 2023 09:52

aashishmalik requested review from shrouti1507 and mihir-4116 November 20, 2023 09:52

krishna2020 reviewed Nov 20, 2023

View reviewed changes

aashishmalik closed this Dec 8, 2023

ItsSudip reopened this Jan 2, 2024

fix: lowercase null check tracl event adobe analytics

7b8dfb7

aashishmalik force-pushed the fix.adobe-toLowercase branch from 585d2db to 7b8dfb7 Compare January 4, 2024 10:47

devops-github-rudderstack added Stale and removed Stale labels Jan 25, 2024

devops-github-rudderstack added Stale and removed Stale labels Feb 16, 2024

devops-github-rudderstack added the Stale label Mar 8, 2024

aashishmalik closed this Mar 8, 2024

devops-github-rudderstack deleted the fix.adobe-toLowercase branch April 5, 2024 01:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: lowercase null check for track event adobe analytics #2840

fix: lowercase null check for track event adobe analytics #2840

aashishmalik commented Nov 20, 2023

krishna2020 Nov 20, 2023 •

edited

Loading

codecov bot commented Nov 21, 2023 •

edited

Loading

sonarqubecloud bot commented Nov 21, 2023

coderabbitai bot commented Jan 4, 2024

Auto Review Skipped

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

sonarqubecloud bot commented Jan 4, 2024

devops-github-rudderstack commented Jan 25, 2024

devops-github-rudderstack commented Feb 16, 2024

devops-github-rudderstack commented Mar 8, 2024

fix: lowercase null check for track event adobe analytics #2840

fix: lowercase null check for track event adobe analytics #2840

Conversation

aashishmalik commented Nov 20, 2023

Description of the change

Type of change

Related issues

Checklists

Development

Code review

krishna2020 Nov 20, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Nov 21, 2023 • edited Loading

Codecov Report

sonarqubecloud bot commented Nov 21, 2023

coderabbitai bot commented Jan 4, 2024

Auto Review Skipped

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

sonarqubecloud bot commented Jan 4, 2024

Quality Gate passed

devops-github-rudderstack commented Jan 25, 2024

devops-github-rudderstack commented Feb 16, 2024

devops-github-rudderstack commented Mar 8, 2024

krishna2020 Nov 20, 2023 •

edited

Loading

codecov bot commented Nov 21, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)