Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: covert toString before toLowercase #2830

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Conversation

aashishmalik
Copy link
Contributor

@aashishmalik aashishmalik commented Nov 15, 2023

Description of the change

This Pr resolves a bugsnag alert, this occured as toLowerCase is applicable only on strings

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@aashishmalik aashishmalik requested a review from a team as a code owner November 15, 2023 19:20
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4a7eaa0) 87.25% compared to head (0fe1d26) 87.25%.

Files Patch % Lines
src/v0/destinations/active_campaign/util.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2830   +/-   ##
========================================
  Coverage    87.25%   87.25%           
========================================
  Files          791      791           
  Lines        29195    29197    +2     
  Branches      6832     6833    +1     
========================================
+ Hits         25473    25475    +2     
  Misses        3377     3377           
  Partials       345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292
Copy link
Contributor

@aashishmalik can we add more description about what issue does this PR solve & also add test-cases for the same ?

src/v0/destinations/braze/transform.js Outdated Show resolved Hide resolved
src/v0/destinations/braze/transform.js Outdated Show resolved Hide resolved
@aashishmalik aashishmalik requested a review from a team as a code owner December 12, 2023 07:09
Copy link
Contributor

coderabbitai bot commented Dec 12, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment from CodeRabbit.
  • You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@aashishmalik aashishmalik requested review from sivashanmukh and a team as code owners December 12, 2023 07:22
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@aashishmalik aashishmalik merged commit bed431e into develop Dec 12, 2023
16 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the fix.braze-bugsnag branch March 13, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants