Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapchat_conversion category mapping #2826

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

aashishmalik
Copy link
Contributor

Description of the change

snapchat_conversion category mapping

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@aashishmalik aashishmalik changed the base branch from develop to release/v1.50.0 November 14, 2023 05:09
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a56d668) 87.11% compared to head (34dff3e) 87.11%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.50.0    #2826   +/-   ##
================================================
  Coverage            87.11%   87.11%           
================================================
  Files                  768      768           
  Lines                28653    28653           
  Branches              6726     6726           
================================================
  Hits                 24960    24960           
  Misses                3350     3350           
  Partials               343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aashishmalik aashishmalik merged commit 2055dab into release/v1.50.0 Nov 14, 2023
14 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the fix.snap-ordercompleted-category branch February 15, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants