feat: mixpanel set once feature onboard #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2820 +/- ##
===========================================
+ Coverage 87.15% 87.16% +0.01%
===========================================
Files 772 772
Lines 28745 28788 +43
Branches 6753 6764 +11
===========================================
+ Hits 25052 25094 +42
- Misses 3350 3351 +1
Partials 343 343 ☔ View full report in Codecov by Sentry. |
shrouti1507
changed the title
shrouti1507
requested review from
koladilip,
sandeepdsvs,
mihir-4116 and
Gauravudia
…former into feat.mp_set_once
|
@shrouti1507 Unit test cases are missing. |
Gauravudia
reviewed
Nov 16, 2023
added |
koladilip
reviewed
Nov 22, 2023
Gauravudia
reviewed
Nov 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
koladilip
approved these changes
Nov 23, 2023
Gauravudia
approved these changes
Nov 23, 2023
anantjain45823
pushed a commit
that referenced
this pull request
Dec 1, 2023
* feat: initial commit * feat: making sure existing functionality is intact * fix: edits for exclusion keys * fix: edits for supporting property paths * fix: delete wrong test case * fix: test cases * fix: removed unnecessary code * fix: adding unit test cases for trimTraits * fix: changing the order of priority in property mapping * fix: edited distinct id logic * fix: small edit * fix: review comments addressed * fix: adding dedicated mappingJson for setOnce * fix: adding all the fields to the dedicated json * fix: addressing review comments * feat: review comments addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
ref: https://developer.mixpanel.com/reference/profile-set-property-once
Observations :
set_oncedoesn’t set / update values of exisiting fieldsset_oncecan be updated bysetpropertyset_oncetraits from the properties which are being set to mixpanel by default or by users choice - not allow re-writes forset_oncetraitsType of change
Related issues
Checklists
Development
Code review