Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix: amplitude page and screen call containg double spaces #2814

Conversation

anantjain45823
Copy link
Contributor

Description of the change

We introduced a change on 07/11/23 where in page calls were sent as Viewed(single space)Page instead of Viewed(double space)Page and similar for screen calls. Since this caused a breaking change we are reverting this fix

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 self-assigned this Nov 9, 2023
@anantjain45823 anantjain45823 requested review from a team as code owners November 9, 2023 16:55
@anantjain45823
Copy link
Contributor Author

It might go as hotfix so don't update branch ( merge develop in it ).
Branch is cut from main

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30e9981) 87.18% compared to head (07e5e40) 87.18%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2814   +/-   ##
========================================
  Coverage    87.18%   87.18%           
========================================
  Files          771      771           
  Lines        28510    28510           
  Branches      6658     6666    +8     
========================================
  Hits         24857    24857           
- Misses        3316     3317    +1     
+ Partials       337      336    -1     
Files Coverage Δ
src/v0/destinations/am/transform.js 97.40% <100.00%> (-0.02%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anantjain45823 anantjain45823 changed the base branch from develop to hotfix/amPageScreenSpaceRevert November 10, 2023 07:08
@anantjain45823 anantjain45823 merged commit 084c6fb into hotfix/amPageScreenSpaceRevert Nov 10, 2023
15 checks passed
@sanpj2292 sanpj2292 deleted the revert.amPageScreenSingleSpaceFix branch November 10, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants