-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add delivery_category as part of contents, remove flattening custom_data in FB conversions #2812
Conversation
…stom_data in FB conversions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2812 +/- ##
===========================================
- Coverage 87.15% 87.11% -0.05%
===========================================
Files 765 768 +3
Lines 28442 28622 +180
Branches 6659 6712 +53
===========================================
+ Hits 24790 24933 +143
- Misses 3315 3346 +31
- Partials 337 343 +6
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added support for delivery_category parameter as part of contents in custom_data.
Please add test case regarding this
Kudos, SonarCloud Quality Gate passed! |
Description of the change
Resolves INT-981
delivery_category
parameter as part ofcontents
incustom_data
.message.properties
before setting them in custom_dataType of change
Related issues
Checklists
Development
Code review