Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delivery_category as part of contents, remove flattening custom_data in FB conversions #2812

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

sandeepdsvs
Copy link
Contributor

@sandeepdsvs sandeepdsvs commented Nov 9, 2023

Description of the change

Resolves INT-981

  • Added support for delivery_category parameter as part of contents in custom_data.
  • Remove FlattenJSON on message.properties before setting them in custom_data
  • Updated the API version to v18.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sandeepdsvs sandeepdsvs marked this pull request as ready for review November 9, 2023 11:07
@sandeepdsvs sandeepdsvs requested a review from a team as a code owner November 9, 2023 11:07
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b17293) 87.15% compared to head (34d3e4a) 87.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2812      +/-   ##
===========================================
- Coverage    87.15%   87.11%   -0.05%     
===========================================
  Files          765      768       +3     
  Lines        28442    28622     +180     
  Branches      6659     6712      +53     
===========================================
+ Hits         24790    24933     +143     
- Misses        3315     3346      +31     
- Partials       337      343       +6     
Files Coverage Δ
src/v0/destinations/facebook_conversions/config.js 100.00% <100.00%> (ø)
.../v0/destinations/facebook_conversions/transform.js 80.55% <100.00%> (ø)
src/v0/destinations/facebook_conversions/utils.js 76.53% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeepdsvs sandeepdsvs requested a review from a team as a code owner November 10, 2023 11:13
Gauravudia
Gauravudia previously approved these changes Nov 10, 2023
Copy link
Contributor

@Gauravudia Gauravudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shrouti1507 shrouti1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support for delivery_category parameter as part of contents in custom_data.

Please add test case regarding this

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sandeepdsvs sandeepdsvs merged commit e82cef8 into develop Nov 13, 2023
13 of 14 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the FBC_delivery_category branch February 14, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants