Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shopify redis metric when there is no data returned for a key #2811

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

Fix the condition for shopify_redis_no_val metric -> no data returned from redis for a key

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 self-assigned this Nov 9, 2023
@anantjain45823 anantjain45823 requested a review from a team as a code owner November 9, 2023 09:13
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c14b689) 87.18% compared to head (55138d0) 87.18%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2811   +/-   ##
========================================
  Coverage    87.18%   87.18%           
========================================
  Files          771      771           
  Lines        28513    28513           
  Branches      6667     6667           
========================================
  Hits         24860    24860           
  Misses        3317     3317           
  Partials       336      336           
Files Coverage Δ
src/v0/sources/shopify/util.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit c02370e into develop Nov 9, 2023
14 checks passed
@anantjain45823 anantjain45823 deleted the fix.shpifyRedismetric branch December 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants