Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update import and export names, default new routes #2810

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Nov 9, 2023

Description of the change

Clean up PR

  • Update the import and export names
  • Changed : ambiguous naming convention used in default exports and morphing during imports
  • Updated: Consistent export and import names
  • Changed default exports to simple exports to avoid ambiguity
  • Updated the usage of new routes in index.ts as we are planning to depreciate legacy routes

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@utsabc utsabc requested review from a team and sivashanmukh as code owners November 9, 2023 06:57
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (0996e81) 87.22% compared to head (12a1764) 87.22%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2810   +/-   ##
========================================
  Coverage    87.22%   87.22%           
========================================
  Files          757      757           
  Lines        28439    28441    +2     
  Branches      6660     6662    +2     
========================================
+ Hits         24805    24807    +2     
  Misses        3299     3299           
  Partials       335      335           
Files Coverage Δ
src/controllers/delivery.ts 58.82% <100.00%> (ø)
src/controllers/eventTest.ts 18.75% <100.00%> (ø)
src/controllers/misc.ts 20.00% <100.00%> (ø)
src/controllers/profile.ts 25.00% <100.00%> (ø)
src/controllers/source.ts 100.00% <100.00%> (ø)
src/controllers/trackingPlan.ts 27.27% <100.00%> (ø)
src/controllers/userTransform.ts 7.46% <100.00%> (ø)
src/controllers/util/index.ts 100.00% <100.00%> (ø)
src/helpers/fetchHandlers.ts 100.00% <100.00%> (ø)
src/helpers/serviceSelector.ts 94.64% <100.00%> (ø)
... and 29 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

koladilip
koladilip previously approved these changes Nov 9, 2023
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/controllers/destination.ts Show resolved Hide resolved
src/controllers/eventTest.ts Show resolved Hide resolved
test/__tests__/sanity.test.js Outdated Show resolved Hide resolved
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@utsabc utsabc merged commit 06c6503 into develop Nov 14, 2023
14 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the chore.cleanup-import-names branch February 11, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants