Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enrich with geo location data during destination transformation #2803
feat: enrich with geo location data during destination transformation #2803
Changes from 22 commits
5bdb63b
0f44408
4bcc8db
0225128
d789f0e
d3d6b72
2249441
6dd5c8b
53fdb76
8fb7668
c2363d0
5bff71f
5bdc2c6
a825926
b782b90
687f2fa
e4c6bb2
2c44999
ee08e4b
8928020
25fb0d7
9c9c9f3
5ef41f5
58fcdce
a61fb53
67aed69
3365332
67f9217
a2f0747
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's
RudderMessage
too -rudder-transformer/src/types/index.ts
Line 178 in e4c6bb2
Do we need both of them ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
RudderMessage
itself but there were too many changes that were needed in order for the tests to pass & compile. So, kind of yes, we need both of them.[Backlog] We have to plan to get rid of both of these types & stick with only one type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is low level struct used in both process & routerTransform flow, so shouldn't the name be neutral ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically it was named as
RouterTransformationRequestData
previously but since the elements in the type were common, I used it as a low-level struct.Tried to change name, there are many files which are using this type. I feel this is a little bigger change & out of scope of this task. May be we can handle this in a backlog item and make a change independent of this task. But yeah, let me know if we are ok with making this change as part of this PR.