Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: marketo: migrate config fields and fix test cases #2789

Merged
merged 21 commits into from
Dec 2, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

Resolves INT-824
We are merging two fields of Marketo Mapping of RS Event to Marketo Primary Key and RS Event to Marketo Activity Id for better User understanding and hence for the same we are making the changes to incorporate those

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 self-assigned this Nov 2, 2023
@anantjain45823 anantjain45823 requested review from a team as code owners November 2, 2023 09:46
koladilip
koladilip previously approved these changes Nov 2, 2023
@anantjain45823 anantjain45823 force-pushed the feat.marketoConfigUpdate branch from 49e952a to ea35d22 Compare November 7, 2023 05:32
@anantjain45823 anantjain45823 requested review from sivashanmukh and a team as code owners November 7, 2023 05:32
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a015460) 87.26% compared to head (316fd08) 87.26%.

❗ Current head 316fd08 differs from pull request most recent head 2abb514. Consider uploading reports for the commit 2abb514 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2789   +/-   ##
========================================
  Coverage    87.26%   87.26%           
========================================
  Files          775      775           
  Lines        28923    28923           
  Branches      6788     6788           
========================================
  Hits         25239    25239           
  Misses        3344     3344           
  Partials       340      340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anantjain45823 anantjain45823 added the DO NOT MERGE Don't merge this PR without having discussion label Nov 10, 2023
koladilip
koladilip previously approved these changes Nov 22, 2023
@anantjain45823 anantjain45823 removed the DO NOT MERGE Don't merge this PR without having discussion label Nov 30, 2023
Copy link
Contributor

coderabbitai bot commented Nov 30, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

sanpj2292
sanpj2292 previously approved these changes Dec 1, 2023
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit 7910dba into develop Dec 2, 2023
14 checks passed
@anantjain45823 anantjain45823 deleted the feat.marketoConfigUpdate branch December 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants