Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dm): added stats for the user transformation batch request #2788

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

abhimanyubabbar
Copy link
Contributor

@abhimanyubabbar abhimanyubabbar commented Nov 2, 2023

Description of the change

Linear Ticket: DAT-333

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@abhimanyubabbar abhimanyubabbar requested review from a team as code owners November 2, 2023 05:04
@abhimanyubabbar abhimanyubabbar changed the title added stats for the user transformation batch request chore(dm): added stats for the user transformation batch request Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (11fb7c4) 87.18% compared to head (22b536a) 87.18%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2788   +/-   ##
========================================
  Coverage    87.18%   87.18%           
========================================
  Files          771      771           
  Lines        28510    28513    +3     
  Branches      6658     6667    +9     
========================================
+ Hits         24857    24860    +3     
- Misses        3316     3317    +1     
+ Partials       337      336    -1     
Files Coverage Δ
src/legacy/router.js 22.82% <ø> (+0.11%) ⬆️
src/services/userTransform.ts 63.00% <ø> (-0.37%) ⬇️
src/util/customTransformer-faas.js 90.74% <100.00%> (-0.93%) ⬇️
src/util/customTransformer.js 84.96% <100.00%> (+0.50%) ⬆️
src/util/customTransformerFactory.js 88.88% <100.00%> (-0.59%) ⬇️
src/util/prometheus.js 7.07% <ø> (ø)
src/util/customTransformer-v1.js 86.27% <95.45%> (-4.64%) ⬇️
src/util/openfaas/index.js 85.33% <95.83%> (+1.04%) ⬆️
src/util/stats.js 56.86% <45.45%> (+0.61%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhimanyubabbar abhimanyubabbar changed the title chore(dm): added stats for the user transformation batch request chore(dm): added stats for the user transformation batch request DAT-333 Nov 2, 2023
@abhimanyubabbar abhimanyubabbar changed the title chore(dm): added stats for the user transformation batch request DAT-333 chore(dm): added stats for the user transformation batch request Nov 2, 2023
@abhimanyubabbar abhimanyubabbar force-pushed the transformer-batch-request-stats branch 2 times, most recently from 718bef4 to ef374e3 Compare November 3, 2023 12:15
@abhimanyubabbar abhimanyubabbar requested review from sivashanmukh and a team as code owners November 6, 2023 09:10
Jayachand
Jayachand previously approved these changes Nov 6, 2023
@abhimanyubabbar abhimanyubabbar force-pushed the transformer-batch-request-stats branch from 33c4867 to 5335ff0 Compare November 6, 2023 10:28
@Jayachand
Copy link
Collaborator

pls fix linting isuues as part of Report Code Coverage

Copy link
Collaborator

@krishna2020 krishna2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For github action failures

Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

87.0% 87.0% Coverage
2.9% 2.9% Duplication

@abhimanyubabbar abhimanyubabbar merged commit b41aebf into develop Nov 8, 2023
14 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the transformer-batch-request-stats branch February 8, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants