Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(INT-305): onboard gladly destination #2786

Merged
merged 26 commits into from
Nov 14, 2023
Merged

Conversation

mihir-4116
Copy link
Contributor

Description of the change

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@mihir-4116 mihir-4116 self-assigned this Nov 1, 2023
@mihir-4116 mihir-4116 requested a review from a team as a code owner November 1, 2023 14:23
@mihir-4116 mihir-4116 changed the title feat: onboard gladly destination feat(INT-305): onboard gladly destination Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6f7d13) 87.11% compared to head (6c11723) 87.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2786      +/-   ##
===========================================
+ Coverage    87.11%   87.15%   +0.04%     
===========================================
  Files          768      772       +4     
  Lines        28653    28743      +90     
  Branches      6726     6751      +25     
===========================================
+ Hits         24960    25050      +90     
  Misses        3350     3350              
  Partials       343      343              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mihir-4116 mihir-4116 requested review from sivashanmukh and a team as code owners November 6, 2023 13:15
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

99.3% 99.3% Coverage
0.0% 0.0% Duplication

@mihir-4116 mihir-4116 merged commit ff80b88 into develop Nov 14, 2023
16 checks passed
@mihir-4116 mihir-4116 deleted the feat.onboard_gladly branch November 14, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants