Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard revenuecat as a source #2774

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Oct 30, 2023

Description of the change

Resolves INT-668

Onboard Revenuecat as a source

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (570532c) 80.37% compared to head (00229e2) 87.18%.

❗ Current head 00229e2 differs from pull request most recent head 0e77707. Consider uploading reports for the commit 0e77707 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2774      +/-   ##
===========================================
+ Coverage    80.37%   87.18%   +6.80%     
===========================================
  Files          302      771     +469     
  Lines        17026    28513   +11487     
  Branches      4195     6658    +2463     
===========================================
+ Hits         13685    24859   +11174     
- Misses        2886     3317     +431     
+ Partials       455      337     -118     
Files Coverage Δ
src/v0/sources/revenuecat/transform.js 100.00% <100.00%> (ø)
test/integrations/sources/revenuecat/data.ts 100.00% <100.00%> (ø)

... and 513 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.3% 90.3% Coverage
0.0% 0.0% Duplication

@yashasvibajpai yashasvibajpai merged commit 55f9637 into develop Nov 6, 2023
12 checks passed
@yashasvibajpai yashasvibajpai deleted the onboard-revenuecat-source branch December 13, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants