Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oom kill while stringifying large response json #2754

Merged
merged 10 commits into from
Oct 26, 2023

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Oct 19, 2023

Description of the change

Resolves INT-229

When there are large messages or large batches of messages being processed for stringification(json stringification), we are getting memory leaks, where in there are huge number of nested stringifications being done.
We are looking to fix it through this PR

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Sai Sankeerth added 2 commits October 19, 2023 20:40
src/v0/util/index.js Outdated Show resolved Hide resolved
Signed-off-by: Sai Sankeerth <[email protected]>
koladilip
koladilip previously approved these changes Oct 20, 2023
- correct test-case implementation of autopilot
- change destinationResponse to any

Signed-off-by: Sai Sankeerth <[email protected]>
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b23a9b) 87.30% compared to head (2b6e263) 87.29%.
Report is 1 commits behind head on develop.

❗ Current head 2b6e263 differs from pull request most recent head 64a97fa. Consider uploading reports for the commit 64a97fa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2754      +/-   ##
===========================================
- Coverage    87.30%   87.29%   -0.02%     
===========================================
  Files          698      698              
  Lines        28657    28656       -1     
  Branches      6791     6791              
===========================================
- Hits         25020    25016       -4     
- Misses        3311     3315       +4     
+ Partials       326      325       -1     
Files Coverage Δ
src/v0/util/index.js 88.09% <100.00%> (+0.21%) ⬆️
...egrations/destinations/autopilot/processor/data.ts 100.00% <ø> (ø)
...estinations/optimizely_fullstack/processor/data.ts 100.00% <ø> (ø)
...ntegrations/destinations/zendesk/processor/data.ts 100.00% <ø> (ø)
...t/integrations/destinations/zendesk/router/data.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 marked this pull request as ready for review October 23, 2023 06:10
@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners October 23, 2023 06:10
@sanpj2292 sanpj2292 requested a review from krishna2020 October 24, 2023 04:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sanpj2292 sanpj2292 merged commit c8baf5b into develop Oct 26, 2023
12 checks passed
@sanpj2292 sanpj2292 deleted the fix.oom-destResp-stringify branch October 26, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants