Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugsnag error for salesforce #2753

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: bugsnag error for salesforce #2753

merged 1 commit into from
Oct 19, 2023

Conversation

sanpj2292
Copy link
Contributor

Description of the change

Fixes this

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Signed-off-by: Sai Sankeerth <[email protected]>
@sanpj2292 sanpj2292 self-assigned this Oct 19, 2023
@sanpj2292 sanpj2292 requested a review from a team as a code owner October 19, 2023 09:43
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (146f1c6) 87.23% compared to head (b17eaf8) 87.23%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2753   +/-   ##
========================================
  Coverage    87.23%   87.23%           
========================================
  Files          698      698           
  Lines        28643    28643           
  Branches      6790     6790           
========================================
  Hits         24987    24987           
  Misses        3326     3326           
  Partials       330      330           
Files Coverage Δ
src/v0/destinations/salesforce/utils.js 91.48% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanpj2292 sanpj2292 merged commit a2ccdad into develop Oct 19, 2023
14 checks passed
@sanpj2292 sanpj2292 deleted the fix.bugsnag-sf branch October 19, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants