Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support filtering component tests by feature and index #2748

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

koladilip
Copy link
Contributor

Description of the change

Now we can use following commands while running component tests:

npm run test:ts -- component --destination=adobe_analytics
npm run test:ts -- component --destination=adobe_analytics --feature=router
npm run test:ts -- component --destination=adobe_analytics --feature=router --index=0

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@koladilip koladilip requested review from sivashanmukh and a team as code owners October 19, 2023 05:31
@koladilip koladilip merged commit 146f1c6 into develop Oct 19, 2023
8 checks passed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koladilip koladilip deleted the feat.component-tests-filtering branch December 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants