Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(INT-562): update component test suite #2744

Merged
merged 27 commits into from
Oct 30, 2023

Conversation

Sanjay-Veernala
Copy link
Contributor

Description of the change

Resolved INT-562

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Sanjay-Veernala Sanjay-Veernala requested review from a team and sivashanmukh as code owners October 18, 2023 11:07
@koladilip koladilip changed the title componentTests(chore): update component test suite chore(componentTests): update component test suite Oct 19, 2023
@koladilip koladilip changed the title chore(componentTests): update component test suite chore(INT-562): update component test suite Oct 19, 2023
testScript.js Outdated Show resolved Hide resolved
testScript_1.js Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@sanpj2292
Copy link
Contributor

  • For all the destinations test.js are not removed.
  • vero.json is not removed.

Can you also fix the conflict and make sure the tests are successful ?

Sai Sankeerth added 3 commits October 23, 2023 13:39
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c8baf5b) 87.04% compared to head (2a08ca9) 87.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2744      +/-   ##
===========================================
+ Coverage    87.04%   87.12%   +0.07%     
===========================================
  Files          716      759      +43     
  Lines        28257    28376     +119     
  Branches      6647     6647              
===========================================
+ Hits         24597    24723     +126     
+ Misses        3324     3317       -7     
  Partials       336      336              
Files Coverage Δ
src/v0/destinations/clevertap/transform.js 98.30% <ø> (ø)
src/v0/destinations/hs/HSTransform-v1.js 91.51% <ø> (ø)
src/v0/destinations/hs/util.js 97.53% <ø> (ø)
...c/v0/destinations/snapchat_conversion/transform.js 95.31% <100.00%> (ø)
...ntegrations/destinations/algolia/processor/data.ts 100.00% <ø> (ø)
.../integrations/destinations/am/dataDelivery/data.ts 100.00% <ø> (ø)
test/integrations/destinations/am/network.ts 100.00% <ø> (ø)
...ntegrations/destinations/appcues/processor/data.ts 100.00% <ø> (ø)
...t/integrations/destinations/appcues/router/data.ts 100.00% <ø> (ø)
...tions/destinations/attentive_tag/processor/data.ts 66.66% <ø> (ø)
... and 72 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sai Sankeerth added 2 commits October 24, 2023 09:51
- remove ts-ignore for attentive_tag processor tests

Signed-off-by: Sai Sankeerth <[email protected]>
utsabc
utsabc previously approved these changes Oct 25, 2023
Signed-off-by: Sai Sankeerth <[email protected]>
ItsSudip
ItsSudip previously approved these changes Oct 27, 2023
sanpj2292
sanpj2292 previously approved these changes Oct 27, 2023
@sanpj2292 sanpj2292 dismissed stale reviews from ItsSudip and themself via ce25191 October 27, 2023 11:28
@utsabc
Copy link
Member

utsabc commented Oct 27, 2023

LGTM from my side comments are not blocking feel free to resolve

sanpj2292
sanpj2292 previously approved these changes Oct 27, 2023
utsabc
utsabc previously approved these changes Oct 27, 2023
@krishna2020 krishna2020 dismissed stale reviews from utsabc and sanpj2292 via 2a08ca9 October 27, 2023 14:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sanpj2292 sanpj2292 requested review from sanpj2292 and utsabc October 28, 2023 06:23
@sanpj2292 sanpj2292 merged commit 3387cb0 into develop Oct 30, 2023
14 checks passed
@sanpj2292 sanpj2292 deleted the chore/update-component-test-suite branch December 14, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants