-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(INT-562): update component test suite #2744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
changed the title
componentTests(chore): update component test suite
chore(componentTests): update component test suite
Oct 19, 2023
koladilip
changed the title
chore(componentTests): update component test suite
chore(INT-562): update component test suite
Oct 19, 2023
sanpj2292
reviewed
Oct 23, 2023
sanpj2292
reviewed
Oct 23, 2023
sanpj2292
reviewed
Oct 23, 2023
Can you also fix the conflict and make sure the tests are successful ? |
…to chore/update-component-test-suite
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2744 +/- ##
===========================================
+ Coverage 87.04% 87.12% +0.07%
===========================================
Files 716 759 +43
Lines 28257 28376 +119
Branches 6647 6647
===========================================
+ Hits 24597 24723 +126
+ Misses 3324 3317 -7
Partials 336 336
☔ View full report in Codecov by Sentry. |
- remove ts-ignore for attentive_tag processor tests Signed-off-by: Sai Sankeerth <[email protected]>
…to chore/update-component-test-suite
utsabc
previously approved these changes
Oct 25, 2023
…to chore/update-component-test-suite
…ed transformation tests Signed-off-by: Sai Sankeerth <[email protected]>
…to chore/update-component-test-suite
…m_audience, fb, fbpixel, clevertap, criteo_audience
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
ItsSudip
previously approved these changes
Oct 27, 2023
sanpj2292
previously approved these changes
Oct 27, 2023
Signed-off-by: Sai Sankeerth <[email protected]>
LGTM from my side comments are not blocking feel free to resolve |
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
Signed-off-by: Sai Sankeerth <[email protected]>
sanpj2292
previously approved these changes
Oct 27, 2023
utsabc
previously approved these changes
Oct 27, 2023
krishna2020
approved these changes
Oct 27, 2023
Kudos, SonarCloud Quality Gate passed! |
sanpj2292
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Resolved INT-562
Type of change
Related issues
Checklists
Development
Code review