Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: salesforce: handle ECONNABORTED error #2732

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

Resolves INT-852
We are getting multiple alerts over many days for ECONNABORTED error which is some network error form salesforce and should be retried from our end.
This PR has a check to convert this to retryable error

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 self-assigned this Oct 17, 2023
@anantjain45823 anantjain45823 requested a review from a team as a code owner October 17, 2023 09:42
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a54075a) 87.28% compared to head (f6674a7) 87.23%.
Report is 20 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2732      +/-   ##
===========================================
- Coverage    87.28%   87.23%   -0.05%     
===========================================
  Files          643      698      +55     
  Lines        28552    28643      +91     
  Branches      6780     6790      +10     
===========================================
+ Hits         24921    24987      +66     
- Misses        3302     3326      +24     
- Partials       329      330       +1     
Files Coverage Δ
src/adapters/utils/networkUtils.js 73.58% <ø> (ø)
src/v0/util/index.js 87.92% <50.00%> (+0.02%) ⬆️

... and 84 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anantjain45823 anantjain45823 requested review from sivashanmukh and a team as code owners October 17, 2023 12:58
@anantjain45823 anantjain45823 requested a review from a team as a code owner October 17, 2023 13:29
@sanpj2292 sanpj2292 self-requested a review October 19, 2023 04:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit 6b23a9b into develop Oct 24, 2023
13 of 14 checks passed
@anantjain45823 anantjain45823 deleted the fix.sfResponseHandler branch December 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants