Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce v1/source/sourceType endpoint #2722

Merged
merged 16 commits into from
Nov 10, 2023

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Oct 16, 2023

Description of the change

Resolves INT-768 and INT-543
We are introducing a new version endpoint for sources in which we will cahnging the structure of the incoming request from
[ {},{} //raw events ],
to
[ { event:{}, //raw event source{} },{ event:{}, //raw event source{} } ]

This PR handles the backward scenario as well which makes it compatible with any server version

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11fb7c4) 87.18% compared to head (1b26094) 87.25%.
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2722      +/-   ##
===========================================
+ Coverage    87.18%   87.25%   +0.06%     
===========================================
  Files          771      772       +1     
  Lines        28510    28550      +40     
  Branches      6658     6670      +12     
===========================================
+ Hits         24857    24910      +53     
+ Misses        3316     3304      -12     
+ Partials       337      336       -1     
Files Coverage Δ
src/controllers/source.ts 100.00% <100.00%> (+14.28%) ⬆️
src/controllers/util/index.ts 100.00% <100.00%> (ø)
src/v1/sources/webhook/transform.js 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/services/source/nativeIntegration.ts Outdated Show resolved Hide resolved
src/services/source/nativeIntegration.ts Outdated Show resolved Hide resolved
src/services/source/nativeIntegration.ts Outdated Show resolved Hide resolved
src/controllers/source.ts Outdated Show resolved Hide resolved
src/controllers/util/index.ts Outdated Show resolved Hide resolved
src/controllers/util/index.ts Outdated Show resolved Hide resolved
src/services/source/nativeIntegration.ts Outdated Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
src/controllers/util/index.ts Outdated Show resolved Hide resolved
src/services/source/nativeIntegration.ts Outdated Show resolved Hide resolved
src/services/source/nativeIntegration.ts Outdated Show resolved Hide resolved
src/services/source/nativeIntegration.ts Outdated Show resolved Hide resolved
src/controllers/source.ts Outdated Show resolved Hide resolved
utsabc
utsabc previously approved these changes Nov 8, 2023
src/types/index.ts Outdated Show resolved Hide resolved
chandumlg
chandumlg previously approved these changes Nov 10, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit 0996e81 into develop Nov 10, 2023
14 checks passed
@anantjain45823 anantjain45823 deleted the feat.sourceV1Intro branch December 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants