-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce v1/source/sourceType endpoint #2722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2722 +/- ##
===========================================
+ Coverage 87.18% 87.25% +0.06%
===========================================
Files 771 772 +1
Lines 28510 28550 +40
Branches 6658 6670 +12
===========================================
+ Hits 24857 24910 +53
+ Misses 3316 3304 -12
+ Partials 337 336 -1
☔ View full report in Codecov by Sentry. |
10 tasks
utsabc
reviewed
Nov 6, 2023
anantjain45823
force-pushed
the
feat.sourceV1Intro
branch
from
November 7, 2023 04:36
96ffba7
to
1fed66a
Compare
utsabc
requested changes
Nov 7, 2023
utsabc
reviewed
Nov 7, 2023
utsabc
reviewed
Nov 7, 2023
utsabc
reviewed
Nov 7, 2023
utsabc
previously approved these changes
Nov 8, 2023
chandumlg
reviewed
Nov 8, 2023
chandumlg
reviewed
Nov 8, 2023
chandumlg
reviewed
Nov 8, 2023
chandumlg
reviewed
Nov 8, 2023
chandumlg
reviewed
Nov 10, 2023
chandumlg
previously approved these changes
Nov 10, 2023
Kudos, SonarCloud Quality Gate passed! |
chandumlg
approved these changes
Nov 10, 2023
utsabc
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR handles the backward scenario as well which makes it compatible with any server version
Type of change
Related issues
Checklists
Development
Code review