feat: facebook pixel audit refactor #2713

sandeepdsvs · 2023-10-11T12:14:07Z

Description of the change

Refactored Facebook Pixel transformer logic. No new features or enhancements, involves minor cleanup and improved modularity.

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

codecov · 2023-10-11T12:22:08Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@4682268). Click here to learn what that means.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2713   +/-   ##
==========================================
  Coverage           ?   87.27%           
==========================================
  Files              ?      643           
  Lines              ?    28543           
  Branches           ?     6778           
==========================================
  Hits               ?    24912           
  Misses             ?     3302           
  Partials           ?      329

Files	Coverage Δ
src/v0/destinations/facebook_pixel/config.js	`100.00% <100.00%> (ø)`
src/v0/destinations/facebook_pixel/transform.js	`98.00% <100.00%> (ø)`
src/v0/destinations/facebook_pixel/utils.js	`97.27% <97.18%> (ø)`