Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new destination tiktok_audience #2710

Merged
merged 15 commits into from
Nov 2, 2023
Merged

Conversation

ItsSudip
Copy link
Member

Description of the change

We are implementing a new audience type destination named Tiktok Audience.
Resolves INT-757

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ItsSudip ItsSudip requested a review from a team as a code owner October 11, 2023 07:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c38f14f) 87.13% compared to head (a74f61e) 87.14%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2710   +/-   ##
========================================
  Coverage    87.13%   87.14%           
========================================
  Files          766      769    +3     
  Lines        28443    28451    +8     
  Branches      6655     6655           
========================================
+ Hits         24785    24793    +8     
  Misses        3321     3321           
  Partials       337      337           
Files Coverage Δ
src/cdk/v2/bindings/default.js 78.26% <100.00%> (+3.26%) ⬆️
src/cdk/v2/destinations/tiktok_audience/config.js 100.00% <100.00%> (ø)
...ons/destinations/tiktok_audience/processor/data.ts 100.00% <100.00%> (ø)
...ations/destinations/tiktok_audience/router/data.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ItsSudip ItsSudip requested review from sivashanmukh and a team as code owners October 18, 2023 12:05
@koladilip
Copy link
Contributor

@ItsSudip I have refactored workflows to use features of json template engine, instead of writing functions all the time.

koladilip
koladilip previously approved these changes Oct 19, 2023
koladilip
koladilip previously approved these changes Oct 20, 2023
@ItsSudip ItsSudip requested a review from koladilip October 27, 2023 06:24
koladilip
koladilip previously approved these changes Oct 27, 2023
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mihir-4116 mihir-4116 merged commit 9bc0fd8 into develop Nov 2, 2023
12 of 14 checks passed
@ItsSudip ItsSudip deleted the feat.tiktok_audience branch December 13, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants