-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: snapchat conversion introduce missing fields #2704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2704 +/- ##
===========================================
+ Coverage 87.21% 87.24% +0.02%
===========================================
Files 640 641 +1
Lines 28470 28519 +49
Branches 6761 6780 +19
===========================================
+ Hits 24831 24880 +49
+ Misses 3312 3310 -2
- Partials 327 329 +2
☔ View full report in Codecov by Sentry. |
sanpj2292
reviewed
Oct 11, 2023
sanpj2292
previously approved these changes
Oct 11, 2023
mihir-4116
previously approved these changes
Oct 11, 2023
sanpj2292
reviewed
Oct 11, 2023
sanpj2292
approved these changes
Oct 11, 2023
mihir-4116
approved these changes
Oct 11, 2023
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Some fields were missing from mapping in
snapchat_conversion
. So all the direct general mappings found are included in this PR.These fields are:
Type of change
Related issues
Checklists
Development
Code review