Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapchat conversion introduce missing fields #2704

Merged
merged 11 commits into from
Oct 11, 2023
Merged

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Oct 10, 2023

Description of the change

Resolves INT-794

Some fields were missing from mapping in snapchat_conversion. So all the direct general mappings found are included in this PR.
These fields are:

  1. click_id
  2. first_name
  3. middle_name
  4. last_name
  5. city
  6. state
  7. country
  8. description
  9. customer_status
  10. uuid_c1
  11. level

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 self-assigned this Oct 10, 2023
@anantjain45823 anantjain45823 requested review from a team as code owners October 10, 2023 04:14
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d681d5e) 87.21% compared to head (fc27699) 87.24%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2704      +/-   ##
===========================================
+ Coverage    87.21%   87.24%   +0.02%     
===========================================
  Files          640      641       +1     
  Lines        28470    28519      +49     
  Branches      6761     6780      +19     
===========================================
+ Hits         24831    24880      +49     
+ Misses        3312     3310       -2     
- Partials       327      329       +2     
Files Coverage Δ
...c/v0/destinations/snapchat_conversion/transform.js 92.21% <87.32%> (-0.93%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sanpj2292
sanpj2292 previously approved these changes Oct 11, 2023
mihir-4116
mihir-4116 previously approved these changes Oct 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

82.1% 82.1% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit d6488d5 into develop Oct 11, 2023
14 checks passed
@anantjain45823 anantjain45823 deleted the fix.snapchat branch December 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants