Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard braze stats #2703

Merged
merged 6 commits into from
Oct 10, 2023
Merged

feat: onboard braze stats #2703

merged 6 commits into from
Oct 10, 2023

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Oct 10, 2023

Description of the change

Onboard stats for braze packing size

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@utsabc utsabc requested review from a team, sivashanmukh and lvrach as code owners October 10, 2023 04:05
@utsabc utsabc requested review from ujjwal-ab and saikumarrs and removed request for a team October 10, 2023 04:05
@utsabc utsabc changed the base branch from master to develop October 10, 2023 04:06
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4ce47ec) 87.20% compared to head (917d1fa) 87.20%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2703   +/-   ##
========================================
  Coverage    87.20%   87.20%           
========================================
  Files          640      640           
  Lines        28461    28467    +6     
  Branches      6759     6762    +3     
========================================
+ Hits         24820    24826    +6     
  Misses        3314     3314           
  Partials       327      327           
Files Coverage Δ
src/v0/destinations/braze/util.js 98.25% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@utsabc utsabc requested a review from ItsSudip October 10, 2023 05:02
@utsabc utsabc merged commit f205325 into develop Oct 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants