Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: destination tests to component test case suite #2698

Merged
merged 14 commits into from
Oct 18, 2023

Conversation

yashasvibajpai
Copy link
Contributor

@yashasvibajpai yashasvibajpai commented Oct 8, 2023

Description of the change

Resolves INT-559

Refactor processor and tests for below destinations to component test cases

algolia
appcues
attentive_tag
autopilot
azure_event_hub
blueshift
branch
campaign_manager
candu
confluent_cloud
courier
criteo_audience
customerio
facebook_offline_conversions
facebook_pixel

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@yashasvibajpai yashasvibajpai self-assigned this Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (de2be59) 87.27% compared to head (74b355b) 87.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2698      +/-   ##
===========================================
- Coverage    87.27%   87.23%   -0.04%     
===========================================
  Files          670      698      +28     
  Lines        28605    28641      +36     
  Branches      6790     6790              
===========================================
+ Hits         24966    24986      +20     
- Misses        3310     3325      +15     
- Partials       329      330       +1     
Files Coverage Δ
...ntegrations/destinations/algolia/processor/data.ts 100.00% <ø> (ø)
...t/integrations/destinations/algolia/router/data.ts 100.00% <ø> (ø)
...ntegrations/destinations/appcues/processor/data.ts 100.00% <ø> (ø)
...t/integrations/destinations/appcues/router/data.ts 100.00% <ø> (ø)
...tions/destinations/attentive_tag/processor/data.ts 66.66% <ø> (ø)
...grations/destinations/attentive_tag/router/data.ts 100.00% <ø> (ø)
...egrations/destinations/autopilot/processor/data.ts 100.00% <ø> (ø)
...integrations/destinations/autopilot/router/data.ts 100.00% <ø> (ø)
...ons/destinations/azure_event_hub/processor/data.ts 100.00% <ø> (ø)
...egrations/destinations/blueshift/processor/data.ts 100.00% <ø> (ø)
... and 18 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashasvibajpai yashasvibajpai changed the title refactor: algolia, appcues, attentive to component tc refactor: processor tests to component test case suite Oct 16, 2023
@yashasvibajpai yashasvibajpai marked this pull request as ready for review October 16, 2023 00:51
@yashasvibajpai yashasvibajpai requested review from sivashanmukh and a team as code owners October 16, 2023 00:51
@yashasvibajpai yashasvibajpai changed the title refactor: processor tests to component test case suite refactor: destination tests to component test case suite Oct 16, 2023
sanpj2292
sanpj2292 previously approved these changes Oct 16, 2023
anantjain45823
anantjain45823 previously approved these changes Oct 16, 2023
ItsSudip
ItsSudip previously approved these changes Oct 18, 2023
anantjain45823
anantjain45823 previously approved these changes Oct 18, 2023
sanpj2292
sanpj2292 previously approved these changes Oct 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yashasvibajpai yashasvibajpai merged commit 5f094bc into develop Oct 18, 2023
13 of 14 checks passed
@yashasvibajpai yashasvibajpai deleted the refactor.algolia.appcues.attentive.tc branch December 13, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants