-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: destination tests to component test case suite #2698
Merged
yashasvibajpai
merged 14 commits into
develop
from
refactor.algolia.appcues.attentive.tc
Oct 18, 2023
Merged
refactor: destination tests to component test case suite #2698
yashasvibajpai
merged 14 commits into
develop
from
refactor.algolia.appcues.attentive.tc
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2698 +/- ##
===========================================
- Coverage 87.27% 87.23% -0.04%
===========================================
Files 670 698 +28
Lines 28605 28641 +36
Branches 6790 6790
===========================================
+ Hits 24966 24986 +20
- Misses 3310 3325 +15
- Partials 329 330 +1
☔ View full report in Codecov by Sentry. |
yashasvibajpai
changed the title
refactor: algolia, appcues, attentive to component tc
refactor: processor tests to component test case suite
Oct 16, 2023
yashasvibajpai
changed the title
refactor: processor tests to component test case suite
refactor: destination tests to component test case suite
Oct 16, 2023
sanpj2292
previously approved these changes
Oct 16, 2023
anantjain45823
previously approved these changes
Oct 16, 2023
yashasvibajpai
dismissed stale reviews from anantjain45823 and sanpj2292
via
October 18, 2023 07:23
e329c5e
ItsSudip
previously approved these changes
Oct 18, 2023
anantjain45823
previously approved these changes
Oct 18, 2023
sanpj2292
previously approved these changes
Oct 18, 2023
yashasvibajpai
dismissed stale reviews from sanpj2292, anantjain45823, and ItsSudip
via
October 18, 2023 09:07
adc726e
Kudos, SonarCloud Quality Gate passed! |
sanpj2292
approved these changes
Oct 18, 2023
anantjain45823
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Resolves INT-559
Type of change
Related issues
Checklists
Development
Code review