Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create instance of transformedObj #2694

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: create instance of transformedObj #2694

merged 1 commit into from
Oct 9, 2023

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Oct 8, 2023

Description of the change

In eventTester.ts file we were declaring some variables but not initializing those. With this fix, we are initializing such variables.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ItsSudip ItsSudip requested review from sivashanmukh and a team as code owners October 8, 2023 13:18
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (75d665d) 87.12% compared to head (3e1f11f) 87.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2694      +/-   ##
===========================================
- Coverage    87.12%   87.12%   -0.01%     
===========================================
  Files          639      639              
  Lines        28414    28416       +2     
  Branches      6738     6738              
===========================================
  Hits         24757    24757              
- Misses        3329     3331       +2     
  Partials       328      328              
Files Coverage Δ
src/controllers/eventTest.ts 18.75% <0.00%> (ø)
src/services/eventTest/eventTester.ts 2.15% <0.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ItsSudip ItsSudip merged commit bbf7ad4 into develop Oct 9, 2023
@ItsSudip ItsSudip deleted the fix.eventTest branch October 9, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants