fix: criteo_aud auth_token expire code incorporated #2685

anantjain45823 · 2023-10-04T11:51:31Z

Description of the change

We have incorporated authorization-token-expired as well for status code 401

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

* fix: bqstream event ordering fix * fix: review comments addressed * fix: importing the common util function * fix: putting both error and successful events logic back * fix: test cases addition and code clean up * fix: code clean up * fix: resolving sonar error * fix: removing network handler for bqstream * fix: refactor process router dest

…2635)

…tercom (#2648) fix bugsnag issue

) fix: fb_error message for invalid type of property value

* feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments

* chore: partial failure handling * chore: code review changes

* chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const

* feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts

… flow (#2669)

fix: refactor adj using opitonal chaining

* fix(dm): updated the stats definition for the tracking plan service * fix(iterable): event id mapping (#2659) * chore(release): 1.43.1 * chore: update release owners (#2661) chore: update release stakeholder --------- Co-authored-by: Abhimanyu Babbar <[email protected]> Co-authored-by: Mihir Bhalala <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Anant Jain <[email protected]> Co-authored-by: Sudip Paul <[email protected]>

)

* chore: move mipanel tests to compoennt test suite * remove old test suite * chore: add global destination for reuse in test cases * chore: refactor mp tests to resue destination * chore: make a common file for common modules * refactor: mp component tests --------- Co-authored-by: Dilip Kola <[email protected]>

codecov · 2023-10-04T11:59:18Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0ecd031) 87.13% compared to head (3520819) 87.12%.
Report is 1 commits behind head on develop.

❗ Current head 3520819 differs from pull request most recent head 249bd86. Consider uploading reports for the commit 249bd86 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2685      +/-   ##
===========================================
- Coverage    87.13%   87.12%   -0.01%     
===========================================
  Files          639      639              
  Lines        28389    28403      +14     
  Branches      6724     6732       +8     
===========================================
+ Hits         24736    24747      +11     
- Misses        3325     3328       +3     
  Partials       328      328

Files	Coverage Δ
.../v0/destinations/criteo_audience/networkHandler.js	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonarqubecloud · 2023-10-04T13:24:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

anantjain45823 · 2023-10-04T15:38:25Z

#2687 continued there

Gauravudia and others added 29 commits September 18, 2023 10:53

fix(mixpanel): batch event ordering (#2608)

36c7f06

fix: use promise for prompts in personalize create tracking script (#…

5fbddd1

…2635)

chore(release): pull main into develop post release v1.42.0 (#2636)

fd6698e

fix(snyk): snyk updated versions merged to oen pr

16a9b8e

Merge branch 'develop' into feat/synk-fixes

5a15022

chore: add ttl values for cache (#2593)

70bdce8

fix(hubspot): add validation for hubspotEvents (#2643)

b49d0ee

Merge branch 'develop' into feat/synk-fixes

b8209d0

fix: add optional chaining for error message in network handler of In…

10a13bc

…tercom (#2648) fix bugsnag issue

Merge branch 'develop' into feat/synk-fixes

7030f53

fix(snyk): removed the new added dependencies

364779c

fix(snyk): removed aws-sdk dependency

08a3535

feat: add circular reference check in flattern json (#2650)

a21ea3a

fix(snyk): fix dependencies version from snyk (#2640)

8422744

chore(release): pull main into develop post release v1.43.0 (#2654)

e7dbd2c

chore: update fb_error message for invalid type of property value (#2656

6fcac7a

) fix: fb_error message for invalid type of property value

feat(iterable): user deletion support (#2621)

c0ab19a

* feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments

feat(gaec): partial failures handling (#2631)

0008277

* chore: partial failure handling * chore: code review changes

chore: move unit tests to correct place for mssql and postgres (#2657)

deddae1

* chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const

feat: add axios mocking to component test-suite (#2638)

100c808

feat: tslint rules enable (#2604)

4d6c4b8

* feat: remove eslint issues * fix: fixed es-lint tests * fix: merge conflicts

fix: add auth status inactive category handling to GA in userDeletion…

b784800

… flow (#2669)

fix: refactor adjust using optional chaining (#2671)

f63b493

fix: refactor adj using opitonal chaining

chore: update error messages of GAOC (#2655)

56c80f2

chore: return 298 for filtered/dropped events in user transformer (#2665

b5d28a3

)

fix: criteo_aud auth_token expire code incorporated

3520819

anantjain45823 requested a review from a team as a code owner October 4, 2023 11:51

anantjain45823 self-assigned this Oct 4, 2023

anantjain45823 requested a review from a team as a code owner October 4, 2023 11:51

anantjain45823 requested review from ujjwal-ab, ItsSudip and sanpj2292 October 4, 2023 11:51

test cases added

249bd86

anantjain45823 changed the base branch from develop to hotfix/hotfix/oct.5 October 4, 2023 15:20

anantjain45823 requested review from sivashanmukh and a team as code owners October 4, 2023 15:20

anantjain45823 mentioned this pull request Oct 4, 2023

fix: criteo_aud auth_token expire code incorporated #2687

Merged

10 tasks

anantjain45823 closed this Oct 4, 2023

anantjain45823 deleted the fix.criteo_aud branch December 13, 2023 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: criteo_aud auth_token expire code incorporated #2685

fix: criteo_aud auth_token expire code incorporated #2685

anantjain45823 commented Oct 4, 2023

codecov bot commented Oct 4, 2023 •

edited

Loading

sonarqubecloud bot commented Oct 4, 2023

anantjain45823 commented Oct 4, 2023

fix: criteo_aud auth_token expire code incorporated #2685

fix: criteo_aud auth_token expire code incorporated #2685

Conversation

anantjain45823 commented Oct 4, 2023

Description of the change

Type of change

Related issues

Checklists

Development

Code review

codecov bot commented Oct 4, 2023 • edited Loading

Codecov Report

sonarqubecloud bot commented Oct 4, 2023

anantjain45823 commented Oct 4, 2023

codecov bot commented Oct 4, 2023 •

edited

Loading