Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: geolocation support for python transformations #2676

Closed
wants to merge 2 commits into from

Conversation

Jayachand
Copy link
Collaborator

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Jayachand Jayachand requested review from a team as code owners September 30, 2023 16:57
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (56c80f2) 87.01% compared to head (d1cf38e) 87.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2676      +/-   ##
===========================================
- Coverage    87.01%   87.01%   -0.01%     
===========================================
  Files          635      635              
  Lines        28303    28306       +3     
  Branches      6715     6717       +2     
===========================================
+ Hits         24629    24631       +2     
- Misses        3340     3341       +1     
  Partials       334      334              
Files Coverage Δ
src/util/openfaas/index.js 86.82% <66.66%> (-0.48%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 changed the base branch from develop to release/v1.44.0 October 3, 2023 05:19
@anantjain45823 anantjain45823 changed the base branch from release/v1.44.0 to develop October 3, 2023 05:20
@Jayachand
Copy link
Collaborator Author

duplicate

@Jayachand Jayachand closed this Oct 3, 2023
@Jayachand Jayachand deleted the feat.geolocationSpportForPython branch October 3, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant