Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate ga, ga360, gcs_datalake, google adwords destinations to component tests #2675

Merged
merged 10 commits into from
Oct 25, 2023

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Sep 29, 2023

Description of the change

Resolves INT-626

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ItsSudip ItsSudip requested review from sivashanmukh and a team as code owners September 29, 2023 15:13
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b23a9b) 87.30% compared to head (a2fe276) 87.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2675      +/-   ##
===========================================
- Coverage    87.30%   87.05%   -0.25%     
===========================================
  Files          698      716      +18     
  Lines        28657    28258     -399     
  Branches      6791     6647     -144     
===========================================
- Hits         25020    24601     -419     
- Misses        3311     3320       +9     
- Partials       326      337      +11     
Files Coverage Δ
...tions/google_adwords_offline_conversions/helper.js 100.00% <100.00%> (ø)
...ns/google_adwords_offline_conversions/transform.js 98.05% <100.00%> (ø)
...ations/google_adwords_offline_conversions/utils.js 94.66% <100.00%> (ø)
...est/integrations/destinations/ga/processor/data.ts 100.00% <ø> (ø)
test/integrations/destinations/ga/router/data.ts 100.00% <100.00%> (ø)
.../integrations/destinations/ga360/processor/data.ts 100.00% <ø> (ø)
...est/integrations/destinations/ga360/router/data.ts 100.00% <100.00%> (ø)
...ations/destinations/gcs_datalake/processor/data.ts 100.00% <100.00%> (ø)
..._adwords_enhanced_conversions/dataDelivery/data.ts 100.00% <100.00%> (ø)
...ons/google_adwords_enhanced_conversions/network.ts 100.00% <100.00%> (ø)
... and 11 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sanpj2292
sanpj2292 previously approved these changes Oct 5, 2023
yashasvibajpai
yashasvibajpai previously approved these changes Oct 16, 2023
@ItsSudip ItsSudip changed the title refactor: migrate ga, ga360, gcs_datalake to component tests refactor: migrate ga, ga360, gcs_datalake, google adwords destinations to component tests Oct 16, 2023
sanpj2292
sanpj2292 previously approved these changes Oct 19, 2023
Sai Sankeerth and others added 2 commits October 21, 2023 08:34
* fix: add timestamp conversion mock
- move timestamp conversion logic to helper & use the helper object
- include common mock logic
- add mocks for all relevant test-cases
- clean-up unnecessary imports

Signed-off-by: Sai Sankeerth <[email protected]>

* fix: remove unnecessary log

Signed-off-by: Sai Sankeerth <[email protected]>

* chore: increase coverage for helper

Signed-off-by: Sai Sankeerth <[email protected]>

---------

Signed-off-by: Sai Sankeerth <[email protected]>
Co-authored-by: Sai Sankeerth <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sanpj2292 sanpj2292 merged commit 52c432c into develop Oct 25, 2023
13 of 14 checks passed
@sanpj2292 sanpj2292 deleted the chore.refactor-testcases branch October 25, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants