-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate ga, ga360, gcs_datalake, google adwords destinations to component tests #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2675 +/- ##
===========================================
- Coverage 87.30% 87.05% -0.25%
===========================================
Files 698 716 +18
Lines 28657 28258 -399
Branches 6791 6647 -144
===========================================
- Hits 25020 24601 -419
- Misses 3311 3320 +9
- Partials 326 337 +11
☔ View full report in Codecov by Sentry. |
sanpj2292
previously approved these changes
Oct 5, 2023
yashasvibajpai
previously approved these changes
Oct 16, 2023
ItsSudip
changed the title
refactor: migrate ga, ga360, gcs_datalake to component tests
refactor: migrate ga, ga360, gcs_datalake, google adwords destinations to component tests
Oct 16, 2023
sanpj2292
previously approved these changes
Oct 19, 2023
…to chore.refactor-testcases
* fix: add timestamp conversion mock - move timestamp conversion logic to helper & use the helper object - include common mock logic - add mocks for all relevant test-cases - clean-up unnecessary imports Signed-off-by: Sai Sankeerth <[email protected]> * fix: remove unnecessary log Signed-off-by: Sai Sankeerth <[email protected]> * chore: increase coverage for helper Signed-off-by: Sai Sankeerth <[email protected]> --------- Signed-off-by: Sai Sankeerth <[email protected]> Co-authored-by: Sai Sankeerth <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
utsabc
approved these changes
Oct 25, 2023
sanpj2292
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review