Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ga4 adding support for pii filters #2674

Closed
wants to merge 2 commits into from
Closed

fix: ga4 adding support for pii filters #2674

wants to merge 2 commits into from

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Sep 29, 2023

Description of the change

Adding support for PII filter for user properties for ga4

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@utsabc utsabc requested a review from a team as a code owner September 29, 2023 14:24
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9fc4545) 86.71% compared to head (92279b5) 86.89%.
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2674      +/-   ##
==========================================
+ Coverage   86.71%   86.89%   +0.17%     
==========================================
  Files         570      604      +34     
  Lines       28126    28117       -9     
  Branches     6713     6695      -18     
==========================================
+ Hits        24389    24431      +42     
+ Misses       3395     3353      -42     
+ Partials      342      333       -9     
Files Coverage Δ
src/v0/destinations/ga4/utils.js 96.80% <100.00%> (ø)
src/v0/destinations/ga4/transform.js 92.19% <50.00%> (ø)

... and 67 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

85.0% 85.0% Coverage
1.2% 1.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mihir-4116
Copy link
Contributor

Changes are not required as it's already merged to release pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants