chore(dm): add tracking plan stat per event level #2673
Conversation
abhimanyubabbar
requested review from
sivashanmukh and
a team
as code owners
| } catch (error) { | ||
| exception = true; | ||
|
|
||
| const errMessage = `Error occurred while validating : ${error}`; | ||
| logger.error(errMessage); |
There was a problem hiding this comment.
add event name in logger to pin point where error happened
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2673 +/- ##
===========================================
+ Coverage 87.01% 87.02% +0.01%
===========================================
Files 635 635
Lines 28296 28301 +5
Branches 6711 6717 +6
===========================================
+ Hits 24621 24629 +8
+ Misses 3341 3338 -3
Partials 334 334
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
| workspaceId: event.metadata?.workspaceId, | ||
| trackingPlanId: event.metadata?.trackingPlanId, | ||
| status: errorReport?.status, | ||
| violationType: errorReport.violationType ? errorReport.violationType : '', |
There was a problem hiding this comment.
one event can have multiple violations. We can stop capturing this info
| @@ -8158,6 +8157,7 @@ | |||
| }, | |||
| "node_modules/available-typed-arrays": { | |||
| "version": "1.0.5", | |||
| "dev": true, | |||
There was a problem hiding this comment.
remove changes from package-lock file
| public static async validateTrackingPlan(events, requestSize, reqParams) { | ||
| /** | ||
| * validate takes in events as argument and iterates over the events | ||
| * validating them using the tracking |
There was a problem hiding this comment.
| * validating them using the tracking | |
| * validating them using the tracking plan |
| ...metaTags, | ||
| }); | ||
| } | ||
| const failure = await eventValidator.handleValidation(parsedEvent); |
There was a problem hiding this comment.
| const failure = await eventValidator.handleValidation(parsedEvent); | |
| const validatedEvent = await eventValidator.handleValidation(parsedEvent); |
|
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
devops-github-rudderstack
deleted the
chore.add-tracking-plan-stat-per-event
branch
Description of the change
Type of change
Related issues
Checklists
Development
Code review