Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move mixpanel tests to component test suite #2668

Merged
merged 8 commits into from
Oct 4, 2023

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

move mixpanel tests to component test suite

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b5d28a3) 87.11% compared to head (8a84152) 87.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2668      +/-   ##
===========================================
+ Coverage    87.11%   87.13%   +0.02%     
===========================================
  Files          636      639       +3     
  Lines        28341    28389      +48     
  Branches      6724     6724              
===========================================
+ Hits         24688    24736      +48     
  Misses        3325     3325              
  Partials       328      328              
Files Coverage Δ
test/integrations/destinations/mp/common.ts 100.00% <100.00%> (ø)
...est/integrations/destinations/mp/processor/data.ts 100.00% <ø> (ø)
test/integrations/destinations/mp/router/data.ts 100.00% <100.00%> (ø)
test/integrations/testUtils.ts 84.44% <100.00%> (+0.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ujjwal-ab ujjwal-ab requested a review from koladilip October 3, 2023 11:39
koladilip
koladilip previously approved these changes Oct 3, 2023
test/integrations/destinations/mp/processor/data.ts Outdated Show resolved Hide resolved
test/integrations/destinations/mp/router/data.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ujjwal-ab ujjwal-ab merged commit 0ecd031 into develop Oct 4, 2023
14 checks passed
@koladilip koladilip deleted the chore.update-mp-test branch December 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants