chore: update component test suite #2664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(iterable): user deletion support * feat(iterable): user deletion improvements * chore: added comments
* chore: partial failure handling * chore: code review changes
* chore: move unit tests to correct place for mssql and postgres * chore: replace var to const * chore: replace var to const
Sanjay-Veernala
requested review from
a team and
sivashanmukh
as code owners
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2664 +/- ##
===========================================
+ Coverage 87.20% 87.22% +0.01%
===========================================
Files 640 643 +3
Lines 28461 28508 +47
Branches 6759 6769 +10
===========================================
+ Hits 24820 24866 +46
- Misses 3314 3315 +1
Partials 327 327 ☔ View full report in Codecov by Sentry. |
sanpj2292
changed the title
sanpj2292
reviewed
Oct 9, 2023
| @@ -23,7 +23,6 @@ | |||
| "ajv": "^8.12.0", | |||
| "ajv-draft-04": "^1.0.0", | |||
| "ajv-formats": "^2.1.1", | |||
| "aws-sdk": "^2.1354.0", | |||
There was a problem hiding this comment.
Any reason we are removing aws-sdk dependency in this PR ?
There was a problem hiding this comment.
I haven't removed it, may happened due to latest pull from base branch
|
Kudos, SonarCloud Quality Gate passed!
|
|
@Sanjay-Veernala We need to move it in the component-test-suit format. This is not yet in the component test suit format. You can check this PR for the reference. |
devops-github-rudderstack
deleted the
chore.update-component-test-suite
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review