chore(release): pull hotfix-release/v1.43.0 into main

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [1.43.0](https://github.com/rudderlabs/rudder-transformer/compare/v1.42.0...v1.43.0) (2023-09-25)
+
+
+### Features
+
+* update google_cloud_function implementation as per custom destination ([#2652](https://github.com/rudderlabs/rudder-transformer/issues/2652)) ([5c981e1](https://github.com/rudderlabs/rudder-transformer/commit/5c981e12c8e203c80229881a07704c6413c842a9))
+
 ## [1.42.0](https://github.com/rudderlabs/rudder-transformer/compare/v1.41.1...v1.42.0) (2023-09-18)
 
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "rudder-transformer",
-  "version": "1.42.0",
+  "version": "1.43.0",
   "description": "",
   "homepage": "https://github.com/rudderlabs/rudder-transformer#readme",
   "bugs": {

src/v0/destinations/google_cloud_function/transform.js

@@ -1,29 +1,19 @@
 const _ = require('lodash');
 const {
-  defaultRequestConfig,
-  defaultPostRequestConfig,
   getSuccessRespEvents,
   checkInvalidRtTfEvents,
   handleRtTfSingleEventError,
 } = require('../../util');
 
-const { generateBatchedPayload, validateDestinationConfig, addHeader } = require('./util');
+const { generateBatchedPayload, validateDestinationConfig } = require('./util');
 
 // Main process Function to handle transformation
 function process(event) {
   const { message, destination } = event;
-  const { googleCloudFunctionUrl } = destination.Config;
-
   // Config Validation
   validateDestinationConfig(destination);
 
-  const response = defaultRequestConfig();
-  // adding header
-  addHeader(response, destination.Config);
-  response.method = defaultPostRequestConfig.requestMethod;
-  response.body.JSON = message;
-  response.endpoint = googleCloudFunctionUrl;
-
+  const response = message;
   return response;
 }
 
@@ -37,7 +27,7 @@ function batchEvents(successRespList, maxBatchSize = 10) {
     const batchEventResponse = generateBatchedPayload(chunk);
     batchedResponseList.push(
       getSuccessRespEvents(
-        batchEventResponse.batchedRequest,
+        batchEventResponse.message,
         batchEventResponse.metadata,
         batchEventResponse.destination,
         true,

src/v0/destinations/google_cloud_function/util.js

@@ -1,77 +1,47 @@
-const { defaultBatchRequestConfig } = require('../../util');
-const { JSON_MIME_TYPE } = require('../../util/constant');
 const { ConfigurationError } = require('../../util/errorTypes');
 
-const { TRIGGERTYPE } = require('./config');
-
 /**
  * validate destination config
  * @param {*} param0
  */
 const validateDestinationConfig = ({ Config }) => {
-  // throw error if google Cloud Function is not provided
+  // throw error if google Cloud Function URL is not provided
   if (!Config.googleCloudFunctionUrl) {
     throw new ConfigurationError('[GCF]:: Url not found. Aborting');
   }
-  if (
-    Config.triggerType === 'https' && // for triggerType https gcloud Authorization is mandatory
-    !Config.gcloudAuthorization
-  ) {
-    throw new ConfigurationError('[GCF]:: Access Token not found. Aborting');
+  if (Config.requireAuthentication && !Config.credentials) {
+    throw new ConfigurationError(
+      '[GCF]:: Service Account credentials are required if your function required authentication. Aborting',
+    );
   }
 };
 
-/**
- * add headers  in the payload that is provided in destination config
- * @param {*} response
- * @param {*} Config
- */
-function addHeader(response, Config) {
-  const { triggerType, apiKeyId, gcloudAuthorization } = Config;
-
-  response.headers = { 'content-type': JSON_MIME_TYPE };
-  if (apiKeyId) {
-    const basicAuth = Buffer.from(`apiKey:${apiKeyId}`).toString('base64');
-    response.headers.ApiKey = `Basic ${basicAuth}`;
-  }
-  if (TRIGGERTYPE.HTTPS === triggerType.toLowerCase()) {
-    response.headers.Authorization = `bearer ${gcloudAuthorization}`;
-  }
-}
-
 /**
  * Create GoogleCloudFunction Batch payload based on the passed events
  * @param {*} events
  * @returns
  */
+
 function generateBatchedPayload(events) {
-  const batchResponseList = [];
   const metadata = [];
   // extracting destination
   // from the first event in a batch
   const { destination } = events[0];
-  const { googleCloudFunctionUrl } = destination.Config;
-  let batchEventResponse = defaultBatchRequestConfig();
+  let batchEventResponse = events.map((event) => event.message);
   // Batch event into dest batch structure
   events.forEach((ev) => {
-    batchResponseList.push(ev.message.body.JSON);
+    // batchResponseList.push(ev.message.body.JSON);
     metadata.push(ev.metadata);
   });
-  batchEventResponse.batchedRequest.body.JSON_ARRAY = {
-    batch: JSON.stringify(batchResponseList),
-  };
-  batchEventResponse.batchedRequest.endpoint = googleCloudFunctionUrl;
-  addHeader(batchEventResponse.batchedRequest, destination.Config);
   batchEventResponse = {
-    ...batchEventResponse,
-    metadata,
+    message: batchEventResponse,
     destination,
+    metadata,
   };
   return batchEventResponse;
 }
 
 module.exports = {
   validateDestinationConfig,
-  addHeader,
   generateBatchedPayload,
 };