Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/snyk fixes test #2633

Closed
wants to merge 37 commits into from
Closed

Feat/snyk fixes test #2633

wants to merge 37 commits into from

Conversation

Sanjay-Veernala
Copy link
Contributor

Description of the change

  • Merged all the open snyk upgarde PRs into one.

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

snyk-bot and others added 30 commits September 8, 2023 03:18
* fix: marketo bulk upload import issue (#2559)

* chore(release): 1.40.2

---------

Co-authored-by: shrouti1507 <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
chore: improce error message for HS
fix(iterable): added support of id parameter for update events
* migrate test cases to new component test suit

* chore: migrate lambda tests

* chore: migrate kochava tests

* chore: migrate lambda tests

* chore: migrate leanplum router tests

* chore: migrate lemnisk tests

* chore: migrate lytics tests

* chore: migrate mailjet tests

* chore: migrate mailmodo tests

* chore: migrate marketo_static_list tests

* chore: migrate moengage tests

* chore: migrate moetate tests

* chore: migrate ometria tests

* chore: migrate one_signal tests

* chore: migrate pagerduty tests

* chore: migrate pinterest_tag tests

* chore: migrate pardot tests
* feat: onboard launchdarkly audience

* docs: add comment

* test: add testcases

* refactor: update identifier logic

* feat: add context kind mapping

* fix: use removeUndefinedNullEmptyExclBoolInt util

* chore: stop sending audience url

* chore: remove extra argument in prepareIdentifiersList

* fix: endpoint

* fix: testcases

* feat: add batching support

* chore: add unit test cases
* feat(mixpanel): add incremental properties support

* docs: add comment

* test: update testcase
* chore: update workflow engine npm pkg name

* fix: workflow engine version in package-lock.json
while preparing the event for profiles<>redis store
* chore: update redis expiry time

* comment addressed

* comment addressed
…and skipped statuses (#2606)

fix: marketo response handler
* feat: onboard fullstory cloud mode

* test: add more tests for identify
…removed and skipped statuses" (#2619)

Revert "fix(INT-339): marketo response handler to handle static list removed and skipped statuses (#2606)"

This reverts commit e3fed49.
anantjain45823 and others added 7 commits September 19, 2023 14:07
…nnel webhook (#2563)

* fix: slack send event to event specific channel

* small fixes

* incorporated legacy method

* added test cases and small fixes

* fixed payload for modern webhooks for not sending app details

* feat:added blacklisted event option
#2598)

* feat: introduce de-activation of authStatus for access_denied or invalid_grant errors

Signed-off-by: Sai Sankeerth <[email protected]>

* fix: test-cases-1

Signed-off-by: Sai Sankeerth <[email protected]>

* chore: remove all references of disable_dest and remove the const disable_dest

Signed-off-by: Sai Sankeerth <[email protected]>

* chore: refactor to use util methods for getting auth error category and access-token

Signed-off-by: Sai Sankeerth <[email protected]>

* fix: pardot router component  test failure and remove unnecessary code

Signed-off-by: Sai Sankeerth <[email protected]>

* fix: remove unused code

---------

Signed-off-by: Sai Sankeerth <[email protected]>
Co-authored-by: Sai Sankeerth <[email protected]>
…and skipped statuses (#2620)

* fix: marketo response handler

* small fix

* chore: comment addressed
* fix(transformation): block ipv6 requests in user transformer

* test cases

* block ips starting with localhost octet

* assign to variable
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 90.70% and project coverage change: +0.03% 🎉

Comparison is base (ed27a11) 86.85% compared to head (9440e39) 86.89%.
Report is 41 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2633      +/-   ##
===========================================
+ Coverage    86.85%   86.89%   +0.03%     
===========================================
  Files          567      603      +36     
  Lines        27964    28129     +165     
  Branches      6661     6693      +32     
===========================================
+ Hits         24288    24442     +154     
- Misses        3342     3354      +12     
+ Partials       334      333       -1     
Files Changed Coverage Δ
src/adapters/networkhandler/authConstants.js 100.00% <ø> (ø)
src/cdk/v2/handler.ts 94.44% <ø> (ø)
src/controllers/misc.ts 20.00% <0.00%> (-13.34%) ⬇️
...ogle_adwords_offline_conversions/networkHandler.js 94.28% <ø> (-0.26%) ⬇️
...ations/google_adwords_offline_conversions/utils.js 94.66% <ø> (+0.32%) ⬆️
src/v0/destinations/iterable/transform.js 95.41% <ø> (ø)
src/v0/destinations/iterable/util.js 94.02% <ø> (-0.45%) ⬇️
src/v0/destinations/klaviyo/util.js 99.20% <ø> (ø)
src/v0/destinations/slack/util.js 92.85% <ø> (ø)
...st/integrations/destinations/lambda/router/data.ts 100.00% <ø> (ø)
... and 65 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@krishna2020
Copy link
Collaborator

@Sanjay-Veernala Raise a new PR, this has unwanted changes

@devops-github-rudderstack devops-github-rudderstack deleted the feat/snyk-fixes-test branch December 20, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.