Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change name of slack properties #2626

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

anantjain45823
Copy link
Contributor

Description of the change

change name of slack config properties

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 requested review from a team and sivashanmukh as code owners September 18, 2023 12:57
@anantjain45823 anantjain45823 changed the base branch from develop to release/v1.42.0 September 18, 2023 12:58
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v1.42.0@3c81c01). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v1.42.0    #2626   +/-   ##
==================================================
  Coverage                   ?   86.89%           
==================================================
  Files                      ?      603           
  Lines                      ?    28140           
  Branches                   ?     6697           
==================================================
  Hits                       ?    24451           
  Misses                     ?     3356           
  Partials                   ?      333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 merged commit 21b19ed into release/v1.42.0 Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants