Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve conflicts #2622

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: resolve conflicts #2622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05d837d
fix: resolve conflicts
shrouti1507 Sep 18, 2023
4c027bc
Merge branch 'fix.bqstream-event-order' into fixing-pr-changes
shrouti1507 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/v0/destinations/bqstream/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@ const {
getDynamicErrorType,
processAxiosResponse,
} = require('../../../adapters/utils/networkUtils');
const { DISABLE_DEST, REFRESH_TOKEN } = require('../../../adapters/networkhandler/authConstants');
const { isHttpStatusSuccess, isDefinedAndNotNull } = require('../../util');
const {
REFRESH_TOKEN,
AUTH_STATUS_INACTIVE,
} = require('../../../adapters/networkhandler/authConstants');
const { proxyRequest } = require('../../../adapters/network');
const { UnhandledStatusCodeError, NetworkError, AbortedError } = require('../../util/errorTypes');
const tags = require('../../util/tags');
Expand All @@ -25,7 +28,7 @@ const trimBqStreamResponse = (response) => ({
* Obtains the Destination OAuth Error Category based on the error code obtained from destination
*
* - If an error code is such that the user will not be allowed inside the destination,
* such error codes fall under DISABLE_DESTINATION
* such error codes fall under AUTH_STATUS_INACTIVE
* - If an error code is such that upon refresh we can get a new token which can be used to send event,
* such error codes fall under REFRESH_TOKEN category
* - If an error code doesn't fall under both categories, we can return an empty string
Expand All @@ -35,7 +38,7 @@ const trimBqStreamResponse = (response) => ({
const getDestAuthCategory = (errorCategory) => {
switch (errorCategory) {
case 'PERMISSION_DENIED':
return DISABLE_DEST;
return AUTH_STATUS_INACTIVE;
case 'UNAUTHENTICATED':
return REFRESH_TOKEN;
default:
Expand Down Expand Up @@ -89,7 +92,7 @@ const getStatusAndCategory = (dresponse, status) => {
* Retryable -> 5[0-9][02-9], 401(UNAUTHENTICATED)
* "Special Cases":
* status=200, resp.insertErrors.length > 0 === Failure
* 403 => AccessDenied -> DISABLE_DEST, other 403 => Just abort
* 403 => AccessDenied -> AUTH_STATUS_INACTIVE, other 403 => Just abort
*
*/
const processResponse = ({ dresponse, status } = {}) => {
Expand Down