Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transformation): block ipv6 requests in user transformer #2618

Merged
merged 5 commits into from
Sep 15, 2023
Merged

fix(transformation): block ipv6 requests in user transformer #2618

merged 5 commits into from
Sep 15, 2023

Conversation

Jayachand
Copy link
Collaborator

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Jayachand Jayachand requested review from a team as code owners September 14, 2023 20:08
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.73% and no project coverage change.

Comparison is base (87d8216) 86.89% compared to head (7b6f01c) 86.89%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2618   +/-   ##
========================================
  Coverage    86.89%   86.89%           
========================================
  Files          603      603           
  Lines        28132    28140    +8     
  Branches      6695     6697    +2     
========================================
+ Hits         24444    24451    +7     
- Misses        3355     3356    +1     
  Partials       333      333
Files Changed Coverage Δ
src/util/utils.js 83.16% <94.73%> (+0.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mihir-4116
mihir-4116 previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@mihir-4116 mihir-4116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

psrikanth88
psrikanth88 previously approved these changes Sep 15, 2023
View reviewed changes
@Jayachand Jayachand dismissed stale reviews from psrikanth88 and mihir-4116 via c99185f September 15, 2023 18:24
psrikanth88
psrikanth88 previously approved these changes Sep 15, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.1% 93.1% Coverage
0.0% 0.0% Duplication

@psrikanth88 psrikanth88 merged commit fd81211 into develop Sep 15, 2023
14 checks passed
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
@Jayachand @Sanjay-Veernala
fix(transformation): block ipv6 requests in user transformer (#2618)
bf9d038 
* fix(transformation): block ipv6 requests in user transformer

* test cases

* block ips starting with localhost octet

* assign to variable
@Jayachand Jayachand deleted the fix.blockIpv6Requests branch September 21, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrikanth88 psrikanth88 psrikanth88 approved these changes

@mihir-4116 mihir-4116 mihir-4116 left review comments

@abhimanyubabbar abhimanyubabbar abhimanyubabbar left review comments

@krishna2020 krishna2020 Awaiting requested review from krishna2020 krishna2020 is a code owner automatically assigned from rudderlabs/integrations

@sandeepdsvs sandeepdsvs Awaiting requested review from sandeepdsvs sandeepdsvs is a code owner automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jayachand @abhimanyubabbar @psrikanth88 @mihir-4116