Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): add destination_id in the key #2615

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

debanjan97
Copy link
Member

while preparing the event for profiles<>redis store

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@debanjan97 debanjan97 added the DO NOT MERGE Don't merge this PR without having discussion label Sep 14, 2023
@debanjan97 debanjan97 requested a review from a team as a code owner September 14, 2023 12:33
@debanjan97
Copy link
Member Author

This PR is to build the image

while preparing the event for profiles<>redis store
@debanjan97 debanjan97 force-pushed the hotfix/redis-profiles-add-dest-id-in-key branch from f07e881 to 55629d6 Compare September 14, 2023 12:44
@debanjan97 debanjan97 requested a review from a team as a code owner September 14, 2023 12:44
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (9fc4545) 86.71% compared to head (55629d6) 86.83%.
Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2615      +/-   ##
===========================================
+ Coverage    86.71%   86.83%   +0.11%     
===========================================
  Files          570      603      +33     
  Lines        28126    28158      +32     
  Branches      6713     6700      -13     
===========================================
+ Hits         24389    24450      +61     
+ Misses        3395     3371      -24     
+ Partials       342      337       -5     
Files Changed Coverage Δ
src/v0/destinations/redis/transform.js 95.74% <100.00%> (+0.09%) ⬆️

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@krishna2020 krishna2020 merged commit 55629d6 into develop Sep 14, 2023
16 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the hotfix/redis-profiles-add-dest-id-in-key branch December 15, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR without having discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants