Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(INT-631): update redis expiry time #2609

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Sep 14, 2023

Description of the change

Updating redis expiry time to 24 hrs

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

sample.env Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 77.48% and no project coverage change.

Comparison is base (55629d6) 86.83% compared to head (b1f605c) 86.83%.
Report is 31 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2609   +/-   ##
========================================
  Coverage    86.83%   86.83%           
========================================
  Files          603      603           
  Lines        28158    28158           
  Branches      6700     6700           
========================================
  Hits         24450    24450           
  Misses        3371     3371           
  Partials       337      337           
Files Changed Coverage Δ
src/cdk/v2/handler.ts 94.44% <ø> (ø)
src/controllers/misc.ts 20.00% <0.00%> (ø)
src/services/trackingPlan.ts 15.78% <0.00%> (ø)
src/services/userTransform.ts 11.11% <0.00%> (ø)
src/util/eventValidation.js 96.73% <ø> (ø)
src/util/prometheus.js 7.07% <ø> (ø)
...st/integrations/destinations/lambda/router/data.ts 100.00% <ø> (ø)
...tegrations/destinations/moengage/processor/data.ts 100.00% <ø> (ø)
...t/integrations/destinations/ometria/router/data.ts 100.00% <ø> (ø)
...grations/destinations/one_signal/processor/data.ts 100.00% <ø> (ø)
... and 40 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anantjain45823 anantjain45823 changed the title chore: update redis expiry time chore(INT-631): update redis expiry time Sep 14, 2023
mihir-4116
mihir-4116 previously approved these changes Sep 14, 2023
aashishmalik
aashishmalik previously approved these changes Sep 14, 2023
sample.env Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@mihir-4116 mihir-4116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anantjain45823 anantjain45823 merged commit b09ded2 into develop Sep 15, 2023
14 checks passed
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
* chore: update redis expiry time

* comment addressed

* comment addressed
@anantjain45823 anantjain45823 deleted the chore.updateRedisExpiryTime branch December 13, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants