Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sonar and lint issues #2607

Merged
merged 3 commits into from
Sep 13, 2023
Merged

chore: fix sonar and lint issues #2607

merged 3 commits into from
Sep 13, 2023

Conversation

krishna2020
Copy link
Collaborator

@krishna2020 krishna2020 commented Sep 13, 2023

Description of the change

PR #2540 introduced lint & sonar issues on src/middleware.js, this PR is to fix those

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 98.27% and project coverage change: +0.01% 🎉

Comparison is base (23bb1f6) 86.94% compared to head (0e8e95d) 86.95%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2607      +/-   ##
===========================================
+ Coverage    86.94%   86.95%   +0.01%     
===========================================
  Files          600      602       +2     
  Lines        28054    28091      +37     
  Branches      6681     6686       +5     
===========================================
+ Hits         24391    24427      +36     
- Misses        3329     3330       +1     
  Partials       334      334              
Files Changed Coverage Δ
src/v0/destinations/twitter_ads/transform.js 93.33% <96.00%> (-0.86%) ⬇️
...dk/v2/destinations/launchdarkly_audience/config.js 100.00% <100.00%> (ø)
...cdk/v2/destinations/launchdarkly_audience/utils.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.8% 71.8% Coverage
0.0% 0.0% Duplication

@krishna2020 krishna2020 marked this pull request as ready for review September 13, 2023 14:00
@krishna2020 krishna2020 requested review from sivashanmukh and a team as code owners September 13, 2023 14:00
@chandumlg chandumlg merged commit 31bd05a into develop Sep 13, 2023
13 checks passed
@chandumlg chandumlg deleted the chore.fix.sonar.issues branch September 13, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants