Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tslint rules enable #2604

Merged
merged 14 commits into from
Sep 29, 2023
Merged

feat: tslint rules enable #2604

merged 14 commits into from
Sep 29, 2023

Conversation

aashishmalik
Copy link
Contributor

@aashishmalik aashishmalik commented Sep 13, 2023

Description of the change

tslint rules enable in tranformer

Change type 'Object' to 'object. Ref. error Don't useObject` as a type.

  • If you want a type meaning "any object", you probably want object instead.
  • If you want a type meaning "any value", you probably want unknown instead.

Create a type for any as wasn't sure on the structure, to remove lint error on further code added to repository .

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (deddae1) 86.93% compared to head (3580acd) 86.98%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2604      +/-   ##
===========================================
+ Coverage    86.93%   86.98%   +0.05%     
===========================================
  Files          605      605              
  Lines        28167    28166       -1     
  Branches      6703     6701       -2     
===========================================
+ Hits         24486    24501      +15     
+ Misses        3348     3332      -16     
  Partials       333      333              
Files Coverage Δ
src/adapters/network.js 81.63% <100.00%> (ø)
src/cdk/v1/dcm_floodlight/transform.js 96.07% <100.00%> (ø)
src/cdk/v1/new_relic/transform.js 90.47% <ø> (ø)
src/cdk/v2/destinations/dcm_floodlight/utils.js 100.00% <100.00%> (ø)
src/cdk/v2/destinations/eloqua/utils.js 100.00% <100.00%> (ø)
...cdk/v2/destinations/launchdarkly_audience/utils.js 100.00% <100.00%> (ø)
src/cdk/v2/utils.ts 96.22% <100.00%> (ø)
src/controllers/destination.ts 84.52% <100.00%> (ø)
src/controllers/profile.ts 25.00% <ø> (-3.58%) ⬇️
src/controllers/regulation.ts 85.18% <ø> (ø)
... and 98 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashishmalik aashishmalik self-assigned this Sep 14, 2023
@aashishmalik aashishmalik marked this pull request as ready for review September 14, 2023 10:25
@aashishmalik aashishmalik requested review from a team and sivashanmukh as code owners September 14, 2023 10:25
koladilip
koladilip previously approved these changes Sep 18, 2023
src/testRouter.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.4% 85.4% Coverage
2.2% 2.2% Duplication

@aashishmalik aashishmalik merged commit 4d6c4b8 into develop Sep 29, 2023
14 checks passed
anantjain45823 added a commit that referenced this pull request Oct 3, 2023
* fix(mixpanel): batch event ordering (#2608)

* fix: bqstream event ordering fix (#2624)

* fix: bqstream event ordering fix

* fix: review comments addressed

* fix: importing the common util function

* fix: putting both error and successful events logic back

* fix: test cases addition and code clean up

* fix: code clean up

* fix: resolving sonar error

* fix: removing network handler for bqstream

* fix: refactor process router dest

* fix: use promise for prompts in personalize create tracking script (#2635)

* fix(snyk): snyk updated versions merged to oen pr

* chore: add ttl values for cache (#2593)

* fix(hubspot): add validation for hubspotEvents (#2643)

* fix: add optional chaining for error message in network handler of Intercom (#2648)

fix bugsnag issue

* fix(snyk): removed the new added dependencies

* fix(snyk): removed aws-sdk dependency

* feat: add circular reference check in flattern json (#2650)

* chore: update fb_error message for invalid type of property value (#2656)

fix: fb_error message for invalid type of property value

* feat(iterable): user deletion support (#2621)

* feat(iterable): user deletion support

* feat(iterable): user deletion improvements

* chore: added comments

* feat(gaec): partial failures handling (#2631)

* chore: partial failure handling

* chore: code review changes

* chore: move unit tests to correct place for mssql and postgres (#2657)

* chore: move unit tests to correct place for mssql and postgres

* chore: replace var to const

* chore: replace var to const

* feat: add axios mocking to component test-suite (#2638)

* feat: tslint rules enable (#2604)

* feat: remove eslint issues

* fix: fixed es-lint tests

* fix: merge conflicts

* fix: add auth status inactive category handling to GA in userDeletion flow (#2669)

* fix: refactor adjust using optional chaining (#2671)

fix: refactor adj using opitonal chaining

* chore(release): pull main into develop post release v1.43.1 (#2662)

* fix(dm): updated the stats definition for the tracking plan service

* fix(iterable): event id mapping (#2659)

* chore(release): 1.43.1

* chore: update release owners (#2661)

chore: update release stakeholder

---------

Co-authored-by: Abhimanyu Babbar <[email protected]>
Co-authored-by: Mihir Bhalala <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Anant Jain <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>

* chore(release): 1.44.0

* feat(ga4): added support of filter user traits (#2679)

* fix: add optional chaining for traits (#2677)

* fix: add optional chaing for traits

* update changelog

* feat: geolocation support for python transformations (#2678)

* feat: geolocation support for python transformations

* chore: updating changelog

---------

Co-authored-by: Anant Jain <[email protected]>

* update changelog

* Update CHANGELOG.md

---------

Co-authored-by: Gauravudia <[email protected]>
Co-authored-by: shrouti1507 <[email protected]>
Co-authored-by: Dilip Kola <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: Sanjay <[email protected]>
Co-authored-by: Siva Shanmukh Vetcha <[email protected]>
Co-authored-by: Ujjwal Abhishek <[email protected]>
Co-authored-by: Mihir Bhalala <[email protected]>
Co-authored-by: Sankeerth <[email protected]>
Co-authored-by: AASHISH MALIK <[email protected]>
Co-authored-by: Anant Jain <[email protected]>
Co-authored-by: Abhimanyu Babbar <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Jayachand <[email protected]>
Co-authored-by: Anant Jain <[email protected]>
anantjain45823 added a commit that referenced this pull request Oct 5, 2023
* fix(dm): updated the stats definition for the tracking plan service

* fix(iterable): event id mapping (#2659)

* chore(release): 1.43.1

* chore: update release owners (#2661)

chore: update release stakeholder

* chore(release): pull release/v1.44.0 into main (#2672)

* fix(mixpanel): batch event ordering (#2608)

* fix: bqstream event ordering fix (#2624)

* fix: bqstream event ordering fix

* fix: review comments addressed

* fix: importing the common util function

* fix: putting both error and successful events logic back

* fix: test cases addition and code clean up

* fix: code clean up

* fix: resolving sonar error

* fix: removing network handler for bqstream

* fix: refactor process router dest

* fix: use promise for prompts in personalize create tracking script (#2635)

* fix(snyk): snyk updated versions merged to oen pr

* chore: add ttl values for cache (#2593)

* fix(hubspot): add validation for hubspotEvents (#2643)

* fix: add optional chaining for error message in network handler of Intercom (#2648)

fix bugsnag issue

* fix(snyk): removed the new added dependencies

* fix(snyk): removed aws-sdk dependency

* feat: add circular reference check in flattern json (#2650)

* chore: update fb_error message for invalid type of property value (#2656)

fix: fb_error message for invalid type of property value

* feat(iterable): user deletion support (#2621)

* feat(iterable): user deletion support

* feat(iterable): user deletion improvements

* chore: added comments

* feat(gaec): partial failures handling (#2631)

* chore: partial failure handling

* chore: code review changes

* chore: move unit tests to correct place for mssql and postgres (#2657)

* chore: move unit tests to correct place for mssql and postgres

* chore: replace var to const

* chore: replace var to const

* feat: add axios mocking to component test-suite (#2638)

* feat: tslint rules enable (#2604)

* feat: remove eslint issues

* fix: fixed es-lint tests

* fix: merge conflicts

* fix: add auth status inactive category handling to GA in userDeletion flow (#2669)

* fix: refactor adjust using optional chaining (#2671)

fix: refactor adj using opitonal chaining

* chore(release): pull main into develop post release v1.43.1 (#2662)

* fix(dm): updated the stats definition for the tracking plan service

* fix(iterable): event id mapping (#2659)

* chore(release): 1.43.1

* chore: update release owners (#2661)

chore: update release stakeholder

---------

Co-authored-by: Abhimanyu Babbar <[email protected]>
Co-authored-by: Mihir Bhalala <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Anant Jain <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>

* chore(release): 1.44.0

* feat(ga4): added support of filter user traits (#2679)

* fix: add optional chaining for traits (#2677)

* fix: add optional chaing for traits

* update changelog

* feat: geolocation support for python transformations (#2678)

* feat: geolocation support for python transformations

* chore: updating changelog

---------

Co-authored-by: Anant Jain <[email protected]>

* update changelog

* Update CHANGELOG.md

---------

Co-authored-by: Gauravudia <[email protected]>
Co-authored-by: shrouti1507 <[email protected]>
Co-authored-by: Dilip Kola <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: Sanjay <[email protected]>
Co-authored-by: Siva Shanmukh Vetcha <[email protected]>
Co-authored-by: Ujjwal Abhishek <[email protected]>
Co-authored-by: Mihir Bhalala <[email protected]>
Co-authored-by: Sankeerth <[email protected]>
Co-authored-by: AASHISH MALIK <[email protected]>
Co-authored-by: Anant Jain <[email protected]>
Co-authored-by: Abhimanyu Babbar <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Jayachand <[email protected]>
Co-authored-by: Anant Jain <[email protected]>

---------

Co-authored-by: Abhimanyu Babbar <[email protected]>
Co-authored-by: Mihir Bhalala <[email protected]>
Co-authored-by: GitHub Actions <[email protected]>
Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: devops-github-rudderstack <[email protected]>
Co-authored-by: Gauravudia <[email protected]>
Co-authored-by: shrouti1507 <[email protected]>
Co-authored-by: Dilip Kola <[email protected]>
Co-authored-by: Sanjay <[email protected]>
Co-authored-by: Siva Shanmukh Vetcha <[email protected]>
Co-authored-by: Ujjwal Abhishek <[email protected]>
Co-authored-by: Sankeerth <[email protected]>
Co-authored-by: AASHISH MALIK <[email protected]>
Co-authored-by: Jayachand <[email protected]>
@devops-github-rudderstack devops-github-rudderstack deleted the feat.eslint-rules-enable branch December 28, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants