Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce de-activation of authStatus for access_denied or inva… #2598

Merged
merged 11 commits into from
Sep 15, 2023

Conversation

sanpj2292
Copy link
Contributor

Description of the change

Introducing de-activation of authStatus for access_denied or invalid_grant errors that we receive from destination
More details about the feature are provided here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sanpj2292 sanpj2292 self-assigned this Sep 12, 2023
@sanpj2292 sanpj2292 requested review from a team and sivashanmukh as code owners September 12, 2023 08:47
@saikumarrs
Copy link
Member

Can you share the link to the rudder-server PR corresponding to these changes, if any?

@sanpj2292
Copy link
Contributor Author

Can you share the link to the rudder-server PR corresponding to these changes, if any?

rudderlabs/rudder-server#3853

Signed-off-by: Sai Sankeerth <[email protected]>
@sanpj2292 sanpj2292 requested a review from a team as a code owner September 12, 2023 09:07
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 96.66% and no project coverage change.

Comparison is base (0f3b39e) 86.87% compared to head (6c7bc49) 86.87%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2598   +/-   ##
========================================
  Coverage    86.87%   86.87%           
========================================
  Files          603      603           
  Lines        28169    28126   -43     
  Branches      6701     6692    -9     
========================================
- Hits         24471    24434   -37     
+ Misses        3361     3356    -5     
+ Partials       337      336    -1     
Files Changed Coverage Δ
src/adapters/networkhandler/authConstants.js 100.00% <ø> (ø)
...ogle_adwords_offline_conversions/networkHandler.js 94.28% <ø> (-0.26%) ⬇️
...ations/google_adwords_offline_conversions/utils.js 94.66% <ø> (+0.32%) ⬆️
...st/integrations/destinations/pardot/router/data.ts 100.00% <ø> (ø)
src/v0/util/index.js 86.88% <93.33%> (+0.21%) ⬆️
...v0/destinations/campaign_manager/networkHandler.js 23.33% <100.00%> (-2.39%) ⬇️
src/v0/destinations/campaign_manager/transform.js 87.37% <100.00%> (+0.46%) ⬆️
...gle_adwords_enhanced_conversions/networkHandler.js 91.48% <100.00%> (-0.67%) ⬇️
...s/google_adwords_enhanced_conversions/transform.js 98.38% <100.00%> (-0.13%) ⬇️
...google_adwords_remarketing_lists/networkHandler.js 96.00% <100.00%> (-0.30%) ⬇️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.4% 89.4% Coverage
0.0% 0.0% Duplication

@sanpj2292 sanpj2292 merged commit 3b1fef6 into develop Sep 15, 2023
14 checks passed
@sanpj2292 sanpj2292 deleted the feat.oauth-access-denied-handling branch September 15, 2023 12:28
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
#2598)

* feat: introduce de-activation of authStatus for access_denied or invalid_grant errors

Signed-off-by: Sai Sankeerth <[email protected]>

* fix: test-cases-1

Signed-off-by: Sai Sankeerth <[email protected]>

* chore: remove all references of disable_dest and remove the const disable_dest

Signed-off-by: Sai Sankeerth <[email protected]>

* chore: refactor to use util methods for getting auth error category and access-token

Signed-off-by: Sai Sankeerth <[email protected]>

* fix: pardot router component  test failure and remove unnecessary code

Signed-off-by: Sai Sankeerth <[email protected]>

* fix: remove unused code

---------

Signed-off-by: Sai Sankeerth <[email protected]>
Co-authored-by: Sai Sankeerth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants