-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce de-activation of authStatus for access_denied or inva… #2598
Conversation
…lid_grant errors Signed-off-by: Sai Sankeerth <[email protected]>
…to feat.oauth-access-denied-handling
Can you share the link to the rudder-server PR corresponding to these changes, if any? |
|
src/v0/destinations/google_adwords_enhanced_conversions/networkHandler.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Sai Sankeerth <[email protected]>
…able_dest Signed-off-by: Sai Sankeerth <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2598 +/- ##
========================================
Coverage 86.87% 86.87%
========================================
Files 603 603
Lines 28169 28126 -43
Branches 6701 6692 -9
========================================
- Hits 24471 24434 -37
+ Misses 3361 3356 -5
+ Partials 337 336 -1
☔ View full report in Codecov by Sentry. |
…nd access-token Signed-off-by: Sai Sankeerth <[email protected]>
…to feat.oauth-access-denied-handling
Signed-off-by: Sai Sankeerth <[email protected]>
…to feat.oauth-access-denied-handling
…to feat.oauth-access-denied-handling
…to feat.oauth-access-denied-handling
Kudos, SonarCloud Quality Gate passed! |
#2598) * feat: introduce de-activation of authStatus for access_denied or invalid_grant errors Signed-off-by: Sai Sankeerth <[email protected]> * fix: test-cases-1 Signed-off-by: Sai Sankeerth <[email protected]> * chore: remove all references of disable_dest and remove the const disable_dest Signed-off-by: Sai Sankeerth <[email protected]> * chore: refactor to use util methods for getting auth error category and access-token Signed-off-by: Sai Sankeerth <[email protected]> * fix: pardot router component test failure and remove unnecessary code Signed-off-by: Sai Sankeerth <[email protected]> * fix: remove unused code --------- Signed-off-by: Sai Sankeerth <[email protected]> Co-authored-by: Sai Sankeerth <[email protected]>
Description of the change
Introducing de-activation of authStatus for access_denied or invalid_grant errors that we receive from destination
More details about the feature are provided here
Type of change
Related issues
Checklists
Development
Code review