Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate fb to component tests #2574

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Sep 8, 2023

Description of the change

Resolves INT-560
Migrating testcases of FB to new format

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ItsSudip ItsSudip requested review from sivashanmukh and a team as code owners September 8, 2023 15:56
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3ff86d4) 86.59% compared to head (bb49455) 86.60%.

Additional details and impacted files
@@                            Coverage Diff                             @@
##           refactor.migrate-test-cases-to-new-format    #2574   +/-   ##
==========================================================================
  Coverage                                      86.59%   86.60%           
==========================================================================
  Files                                            563      563           
  Lines                                          27796    27772   -24     
  Branches                                        6656     6648    -8     
==========================================================================
- Hits                                           24071    24052   -19     
+ Misses                                          3369     3365    -4     
+ Partials                                         356      355    -1     
Files Changed Coverage Δ
...est/integrations/destinations/fb/processor/data.ts 100.00% <100.00%> (ø)
test/integrations/destinations/fb/router/data.ts 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

74.4% 74.4% Coverage
10.6% 10.6% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ItsSudip ItsSudip merged commit 1166bee into refactor.migrate-test-cases-to-new-format Sep 12, 2023
@ItsSudip ItsSudip deleted the refactor.migrate-fb_to_component_tests branch September 12, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant