Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(INT-580): messageId to event_id mapping support #2570

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

mihir-4116
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@mihir-4116 mihir-4116 added enhancement New feature or request Ready for Review labels Sep 8, 2023
@mihir-4116 mihir-4116 requested a review from a team as a code owner September 8, 2023 05:59
@mihir-4116 mihir-4116 self-assigned this Sep 8, 2023
@mihir-4116 mihir-4116 requested review from saikumarrs and removed request for a team September 8, 2023 05:59
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dfd6af6) 86.84% compared to head (72f87bf) 86.84%.

Additional details and impacted files
@@              Coverage Diff               @@
##           hotfix/sep.11    #2570   +/-   ##
==============================================
  Coverage          86.84%   86.84%           
==============================================
  Files                566      566           
  Lines              27946    27946           
  Branches            6655     6655           
==============================================
  Hits               24271    24271           
  Misses              3342     3342           
  Partials             333      333           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@mihir-4116 mihir-4116 changed the title feat(tiktok_ads): messageId to event_id mapping support feat(INT-580): messageId to event_id mapping support Sep 8, 2023
@mihir-4116 mihir-4116 changed the title feat(INT-580): messageId to event_id mapping support feat(tiktok_ads): messageId to event_id mapping support Sep 8, 2023
@mihir-4116 mihir-4116 changed the title feat(tiktok_ads): messageId to event_id mapping support feat(INT-580): messageId to event_id mapping support Sep 8, 2023
Copy link
Contributor

@anantjain45823 anantjain45823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add test cases as well?

@mihir-4116 mihir-4116 merged commit b38843b into hotfix/sep.11 Sep 8, 2023
13 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the feat.tik_tok_ads_mapping_update branch December 9, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants