-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bqstream): event ordering #2558
Conversation
…to fix.bqstream-event-order
…to fix.bqstream-event-order
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2558 +/- ##
===========================================
- Coverage 86.89% 86.78% -0.11%
===========================================
Files 603 568 -35
Lines 28140 28066 -74
Branches 6697 6691 -6
===========================================
- Hits 24451 24358 -93
- Misses 3356 3367 +11
- Partials 333 341 +8
☔ View full report in Codecov by Sentry. |
userId: 'user123', | ||
}, | ||
{ | ||
jobId: 6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jobId: 6 is repeated. Can you make sure jobIds are provided correctly.
Also, can we trim down the test case with not needed fields. Very difficult to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Kudos, SonarCloud Quality Gate passed! |
The PR working tree got disrupted after 2c77215. We have opened a new PR mentioned above. So closing this PR. |
Description of the change
Fixing event ordering issue for BQ stream.
Dividing events to different user journeys and keeping the order of the events intact.
Type of change
Related issues
Checklists
Development
Code review