Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bqstream): event ordering #2558

Closed
wants to merge 20 commits into from
Closed

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Sep 6, 2023

Description of the change

resolves INT-389

Fixing event ordering issue for BQ stream.
Dividing events to different user journeys and keeping the order of the events intact.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@shrouti1507 shrouti1507 changed the title Fix.bqstream event order fix(bq stream): event ordering Sep 8, 2023
@shrouti1507 shrouti1507 changed the title fix(bq stream): event ordering fix(bqstream): event ordering Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 92.96% and project coverage change: -0.11% ⚠️

Comparison is base (fd81211) 86.89% compared to head (dbb06ac) 86.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2558      +/-   ##
===========================================
- Coverage    86.89%   86.78%   -0.11%     
===========================================
  Files          603      568      -35     
  Lines        28140    28066      -74     
  Branches      6697     6691       -6     
===========================================
- Hits         24451    24358      -93     
- Misses        3356     3367      +11     
- Partials       333      341       +8     
Files Changed Coverage Δ
src/adapters/networkhandler/authConstants.js 100.00% <ø> (ø)
src/cdk/v2/handler.ts 94.44% <ø> (ø)
src/controllers/misc.ts 33.33% <ø> (+13.33%) ⬆️
src/routes/misc.ts 100.00% <ø> (ø)
src/v0/destinations/klaviyo/util.js 99.20% <ø> (ø)
src/v0/destinations/mp/transform.js 97.59% <ø> (+0.22%) ⬆️
src/v0/destinations/slack/util.js 92.85% <ø> (ø)
.../integrations/destinations/bqstream/router/data.ts 100.00% <ø> (ø)
src/v0/destinations/marketo/util.js 85.00% <40.00%> (-5.70%) ⬇️
...v0/destinations/campaign_manager/networkHandler.js 25.71% <50.00%> (+2.38%) ⬆️
... and 31 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrouti1507 shrouti1507 marked this pull request as ready for review September 8, 2023 09:09
@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners September 8, 2023 09:09
@shrouti1507 shrouti1507 added the enhancement New feature or request label Sep 8, 2023
mihir-4116
mihir-4116 previously approved these changes Sep 8, 2023
koladilip
koladilip previously approved these changes Sep 11, 2023
@mihir-4116 mihir-4116 self-requested a review September 11, 2023 10:18
koladilip
koladilip previously approved these changes Sep 11, 2023
userId: 'user123',
},
{
jobId: 6,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobId: 6 is repeated. Can you make sure jobIds are provided correctly.

Also, can we trim down the test case with not needed fields. Very difficult to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@shrouti1507 shrouti1507 requested review from a team as code owners September 18, 2023 05:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

87.6% 87.6% Coverage
0.0% 0.0% Duplication

@shrouti1507 shrouti1507 mentioned this pull request Sep 18, 2023
10 tasks
@shrouti1507
Copy link
Contributor Author

The PR working tree got disrupted after 2c77215. We have opened a new PR mentioned above. So closing this PR.

@devops-github-rudderstack devops-github-rudderstack deleted the fix.bqstream-event-order branch December 19, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants