Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mixpanel): add incremental properties support #2550

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Sep 5, 2023

Description of the change

Resolves INT-190
Add mixpanel incremental properties support
Incremental properties will be send in Track call using mixpanel /engage endpoint.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Gauravudia Gauravudia requested a review from a team as a code owner September 5, 2023 13:00
@Gauravudia Gauravudia self-assigned this Sep 5, 2023
@Gauravudia Gauravudia requested a review from a team as a code owner September 5, 2023 13:00
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: -0.09% ⚠️

Comparison is base (23bb1f6) 86.94% compared to head (693a20c) 86.85%.
Report is 2 commits behind head on develop.

❗ Current head 693a20c differs from pull request most recent head 83e0e72. Consider uploading reports for the commit 83e0e72 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2550      +/-   ##
===========================================
- Coverage    86.94%   86.85%   -0.09%     
===========================================
  Files          600      567      -33     
  Lines        28054    27981      -73     
  Branches      6681     6670      -11     
===========================================
- Hits         24391    24304      -87     
- Misses        3329     3342      +13     
- Partials       334      335       +1     
Files Changed Coverage Δ
src/v0/destinations/mp/transform.js 97.36% <94.11%> (-0.23%) ⬇️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.1% 87.1% Coverage
0.0% 0.0% Duplication

@Gauravudia Gauravudia requested a review from ItsSudip September 11, 2023 04:49
Copy link
Contributor

@mihir-4116 mihir-4116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihir-4116
Copy link
Contributor

@Gauravudia can you check why Report Code Coverage action is failing?

@Gauravudia Gauravudia merged commit e98ea84 into develop Sep 14, 2023
5 of 6 checks passed
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
* feat(mixpanel): add incremental properties support

* docs: add comment

* test: update testcase
@saikumarrs saikumarrs deleted the feat/mixpanel-incremental-properties branch December 13, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants