Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboard plugin architecture #2539

Merged
merged 9 commits into from
Oct 12, 2023
Merged

feat: onboard plugin architecture #2539

merged 9 commits into from
Oct 12, 2023

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Aug 31, 2023 •
edited
Loading

Description of the change

Onboarding Plugin Architecture to transformer

https://www.notion.so/rudderstacks/Integration-Plugin-Architecture-Proj-bc1719a23aac4e92b70d61fa1783b1f9#5c365c313ebb45968ddb9820c62eff60

https://www.notion.so/rudderstacks/Integration-Plugin-26ff1465dd9b44f1b3a80239651152a5

Resolves: INT-611

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@utsabc utsabc requested review from a team and sivashanmukh as code owners August 31, 2023 13:36
@utsabc utsabc requested review from yashasvibajpai and mihir-4116 and removed request for a team August 31, 2023 13:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.4% 0.4% Coverage
0.6% 0.6% Duplication

@utsabc utsabc merged commit c2edf16 into feat.plugin-arch Oct 12, 2023
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh

@yashasvibajpai yashasvibajpai Awaiting requested review from yashasvibajpai yashasvibajpai was automatically assigned from rudderlabs/integrations

@mihir-4116 mihir-4116 Awaiting requested review from mihir-4116 mihir-4116 was automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utsabc @koladilip