Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onboard launchdarkly audience #2529

Merged
merged 20 commits into from
Sep 13, 2023
Merged

feat: onboard launchdarkly audience #2529

merged 20 commits into from
Sep 13, 2023

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Aug 29, 2023 •
edited
Loading

Description of the change

Resolves INT-251
Onboarding LaunchDarkly Audience destination.
This integration allows you to import audiences from RudderStack to LaunchDarkly, enabling more efficient targeting and delivery of feature flags

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Gauravudia Gauravudia added the enhancement New feature or request label Aug 29, 2023
@Gauravudia Gauravudia self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (23bb1f6) 86.94% compared to head (811ae17) 86.95%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2529      +/-   ##
===========================================
+ Coverage    86.94%   86.95%   +0.01%     
===========================================
  Files          600      602       +2     
  Lines        28054    28087      +33     
  Branches      6681     6685       +4     
===========================================
+ Hits         24391    24424      +33     
  Misses        3329     3329              
  Partials       334      334
Files Changed Coverage Δ
...dk/v2/destinations/launchdarkly_audience/config.js 100.00% <100.00%> (ø)
...cdk/v2/destinations/launchdarkly_audience/utils.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia marked this pull request as ready for review August 29, 2023 10:36
@Gauravudia Gauravudia requested review from a team as code owners August 29, 2023 10:36
@Gauravudia Gauravudia requested review from krishna2020, saikumarrs and ItsSudip and removed request for saikumarrs August 29, 2023 10:36
@Gauravudia Gauravudia removed the request for review from yashasvibajpai August 31, 2023 11:02
ItsSudip
ItsSudip previously approved these changes Sep 5, 2023
View reviewed changes
krishna2020
krishna2020 previously approved these changes Sep 12, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.6% 97.6% Coverage
0.0% 0.0% Duplication

@Gauravudia Gauravudia merged commit 082e1d1 into develop Sep 13, 2023
10 checks passed
Sanjay-Veernala pushed a commit that referenced this pull request Sep 20, 2023
@Gauravudia @Sanjay-Veernala
feat: onboard launchdarkly audience (#2529)
f7d0441 
* feat: onboard launchdarkly audience

* docs: add comment

* test: add testcases

* refactor: update identifier logic

* feat: add context kind mapping

* fix: use removeUndefinedNullEmptyExclBoolInt util

* chore: stop sending audience url

* chore: remove extra argument in prepareIdentifiersList

* fix: endpoint

* fix: testcases

* feat: add batching support

* chore: add unit test cases
@devops-github-rudderstack devops-github-rudderstack deleted the feat/launchdarkly-audience branch December 13, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsSudip ItsSudip ItsSudip approved these changes

@krishna2020 krishna2020 krishna2020 approved these changes

Assignees

@Gauravudia Gauravudia

Labels
enhancement New feature or request Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauravudia @krishna2020 @ItsSudip