-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(INT-851): api contract tests #2403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but how are we planning to use it for actual destinations, we need to check all destinations and the problem is inputs, should we try to integrate this with component framework ujjawal worked on
Not sure about the component test framework. But right now, we don't have any tests to make sure that transformer strictly follows the contract it has with rudder-server. These tests ensure that the contract is followed and fail if it is not followed. It already identified close to ~10 destinations which don't follow the contract. Once those destinations are fixed. We can merge this. CC @krishna2020 Calls to the destinations are mocked (just like we do now). Input test cases are minimal now, we can add more. |
}, | ||
"destination": { | ||
"Config": { | ||
"apiKey": "abcde", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may be different for different destinations right? are we not getting errors?
c3d659e
to
cbe8872
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Description of the change
Introducing api contract tests.
Type of change
Checklists
Development
Code review