Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(INT-851): api contract tests #2403

Closed
wants to merge 7 commits into from
Closed

Conversation

chandumlg
Copy link
Member

Description of the change

Introducing api contract tests.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@chandumlg chandumlg requested review from a team as code owners July 26, 2023 02:14
@chandumlg chandumlg changed the title Chore.integration tests chore: integration tests Jul 26, 2023
Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but how are we planning to use it for actual destinations, we need to check all destinations and the problem is inputs, should we try to integrate this with component framework ujjawal worked on

@chandumlg
Copy link
Member Author

chandumlg commented Jul 26, 2023

This is good but how are we planning to use it for actual destinations, we need to check all destinations and the problem is inputs, should we try to integrate this with component framework ujjawal worked on

Not sure about the component test framework. But right now, we don't have any tests to make sure that transformer strictly follows the contract it has with rudder-server. These tests ensure that the contract is followed and fail if it is not followed. It already identified close to ~10 destinations which don't follow the contract.

Once those destinations are fixed. We can merge this. CC @krishna2020

Calls to the destinations are mocked (just like we do now). Input test cases are minimal now, we can add more.

},
"destination": {
"Config": {
"apiKey": "abcde",
Copy link
Contributor

@koladilip koladilip Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may be different for different destinations right? are we not getting errors?

@chandumlg chandumlg force-pushed the chore.integration-tests branch from c3d659e to cbe8872 Compare August 15, 2023 15:30
@chandumlg chandumlg changed the title chore: integration tests chore: api contract tests Aug 15, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koladilip koladilip changed the title chore: api contract tests chore(INT-850): api contract tests Oct 18, 2023
@koladilip koladilip changed the title chore(INT-850): api contract tests chore(INT-851): api contract tests Oct 18, 2023
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@ItsSudip ItsSudip deleted the chore.integration-tests branch December 13, 2023 14:37
@krishna2020 krishna2020 restored the chore.integration-tests branch December 28, 2023 14:09
@devops-github-rudderstack devops-github-rudderstack deleted the chore.integration-tests branch January 5, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants